Loading time still not acceptable

Here is the loading time I experience on alpha.happy-dev.fr (1'15''):

To have a reference, here is Rocket Chat (15''):

I have a hard time stating what is acceptable, but this is not.

changed milestone to %Previously done stuff

By Alexandre on 2020-03-06T10:38:03 (imported from GitLab project)

added 1 deleted label

@balessan, @matthieu I created this issue that might be the same as https://git.happy-dev.fr/startinblox/applications/sib-app/issues/399 and https://git.happy-dev.fr/startinblox/applications/sib-app/issues/403.

Feel free to close it if it is. Otherwise... feel free to fix it :-D

I'm available for debugging and testing. Do not hesitate to ask. @rachel also is.

By Alexandre on 2020-03-06T10:40:51 (imported from GitLab project)

@balessan @clement can you reproduce this? I tested and I load the whole page with an average of 8sec

@matthieu Test on Firefox. I send you my credentials.

By Alexandre on 2020-03-09T10:29:06 (imported from GitLab project)

My tests on Firefox:

• I see the conversation after about 12 seconds on https://alpha.happy-dev.fr/circle/@https~@_api~!alpha~!happy-dev~!fr~_circles~_12~.
• I see the conversation after about 6 seconds on https://chat.happy-dev.fr/channel/-new_projects.

Ok I tested with your credentials @alexandre, and I'm around 28 seconds on Firefox. Not as slow as you but still very slow

@alexandre can you test the app on your computer after some modifications? Here is what I did before running it:

• use api.alpha endpoints
• use master branch
• comment these 3 lines about sib-badge

It's much faster like this. I'm not sure what the problem is yet, but if it's the same for you, I'll investigate this way

I think it is related to the badges. For example, with your account @alexandre, you have 79 sib-badge (one for each discussion/circle).

Each badge is filtering the full inbox (303 resources) to display the number of related resources. In addition, it has to deal with asynchronicity to filter resources, and it re-renders every 30 seconds.

In conclusion, if we want to speed up the app, we need to find another way to make the sib-badge work. Maybe by going full JS?

What do you think @clement @balessan @sylvain?

@matthieu : could you get some performance tests results with and without the badges ? Did you try that and do you have some results already ?

What do you mean by going full JS ?

Looks like event listeners are killing us, both on the "active" attribute management and in this case right ?

I tried with @alexandre account and firefox. I get 8 seconds of loading without the badges, and 28 sec with it.

The problem here is not the amount of event listeners, but more the number of operations with AsyncIterators I think.

By full JS, I mean that instead of writing a sib-badge like this

sib-display
  bind-user
  nested-field="inbox"
  search-fields="object"
  search-value-object="conversation_id"

We could use the store to get the resource directly in javascript, and count the results. But the performances may not improve a lot as we still have to filter the resources first

As discussed with Matthieu, we're replacing the current badges by a centralized calculation or all notification counts as a temporary measure.

Matthieu, please note to consider this performance issue in the architecture refactoring were working on.

You guys rock! Tell me when I can test somewhere :-)

By Alexandre on 2020-03-10T14:28:56 (imported from GitLab project)

what about this issue @alexbourlier? I think it has been pushed on alpha, is it better now?

Much much better!! Thank you

Should we close this? or can we still improve something?

In my opinion, it can be closed.

mentioned in issue management/core-team#2

changed milestone to %Performance part I

closed