Error messages on forms

If you don't set a date on a job offer, it is not created (404) but you are still brought to the list of offers instead of having an error message and remaining on the creation form.

EDIT Justine reported the same behavior, because she didn't include https:// in front of the website value on her user profile. We need error messages.

@alexbourlier yes basically this is happening with all fields that should be mandatory...

In the good old days, the form wasn't switched to the next view I believe.

@balessan is this normal behavior of the router?

In those good old days, I believe that the form never switch to the next view, even when successfully save the job offer, isn't it?

Should be fixed when switching to 0.11/0.12, the next management was patched in 0.11

But the error should be a 400 not a 404.

Might be a 400 indeed.

changed title from Silent 404 when you do not set a date on a job offer to Error messages on forms

changed the description

@jbpasquier From what I understand, it will take months for the framework to come up with error messages in forms. We need something that works in the meantime, I get but reports about silently failing form submissions everyday.

Suggestions?

Custom widgets everywhere on every forms

Well, sad to hear but we can't seriously have an app in production without forma validation, that is just not working. So I'd finance this, whatever the cost is.

I'll skim our forms and check how much work that would involve.

In my mind it is not that expensive but I might underestimate the number of widgets needed.

@alexbourlier : I do not get how you reached that conclusion after my answer + Matthieu answer on the SIB-core channel:

From what I understand, it will take months for the framework to come up with error messages in forms.

Yes, we do have an implementation available on 0.11 which is really basic and won't help yourselves a lot (I think) because the main limitation of it is that it sends an array of errors which mentions the name of the fields on the backend side, so it can be confusing for the end-user.

What kind of validations are you waiting for ? Does the required-* isn't enough to provide like 80% percent of the mentioned failures ?

You have to understand that complete form validation will be implemented client side through shapes, on which nobody has any experience for now.

@balessan Hmmm... I think you said you were investigating shapes, and that sounded like something in production in 2021 to me, but I may very well have missed something.

I agree that required-* should tackle many. And then some custom stuff like a URL field on the profile, no accent on the username field. This kind of small validations. In my mind it is quick to cover them.

assigned to @jbpasquier

mentioned in merge request !218 (merged)

mentioned in merge request !219 (merged)

closed via merge request !219 (merged)