From 5d64b1b4238f0befb27e05d5da4151b9ed50a627 Mon Sep 17 00:00:00 2001
From: Benoit Alessandroni <benoit@happy-dev.fr>
Date: Thu, 14 May 2020 00:14:22 +0200
Subject: [PATCH] Fixing useless calls to refresh pagination

---
 src/scripts/coopstarter.js | 50 +++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 28 deletions(-)

diff --git a/src/scripts/coopstarter.js b/src/scripts/coopstarter.js
index 15754846..20c6e9ec 100644
--- a/src/scripts/coopstarter.js
+++ b/src/scripts/coopstarter.js
@@ -246,34 +246,28 @@ function InitManagementForType() {
   var forms = document.querySelectorAll(".resource_by_step");
 
   forms.forEach(form => {
-    form.addEventListener(
-      "populate",
-      e => {
-        window.setTimeout(() => {
-          let type_hidden_field = form.querySelectorAll('select[name="type"]');
-          type_hidden_field.forEach(function(select_hidden) {
-            options_hidden = select_hidden.getElementsByTagName("option");
-            for (let option_hidden of options_hidden) {
-              option_hidden.removeAttribute("selected");
-              str = option_hidden.value
-
-              if (str.substr(str.length - 10) == 'types/1/"}') {
-                //Actually selecting the option if it is the good one
-                option_hidden.setAttribute("selected", "selected");
-                select_hidden.setAttribute("value", option_hidden.value);
-              }
-            }
-            
-            //Trigerring a reload of the associated form
-            let parent_form = select_hidden.closest("sib-form");
-            parent_form.component.inputChange();
-            parent_form.dispatchEvent(new CustomEvent('formChange'));
-            refreshPagination();
-          });
-        });
-      },
-      3000
-    );
+    form.addEventListener("populate", e => {
+      let type_hidden_field = form.querySelectorAll('select[name="type"]');
+      type_hidden_field.forEach(function(select_hidden) {
+        options_hidden = select_hidden.getElementsByTagName("option");
+        for (let option_hidden of options_hidden) {
+          option_hidden.removeAttribute("selected");
+          str = option_hidden.value
+
+          if (str.substr(str.length - 10) == 'types/1/"}') {
+            //Actually selecting the option if it is the good one
+            option_hidden.setAttribute("selected", "selected");
+            select_hidden.setAttribute("value", option_hidden.value);
+          }
+        }
+        
+        //Trigerring a reload of the associated form
+        let parent_form = select_hidden.closest("sib-form");
+        parent_form.component.inputChange();
+        parent_form.dispatchEvent(new CustomEvent('formChange'));
+        refreshPagination();
+      });
+    });
   });
 }
 
-- 
GitLab