From cdaf075ff46dd51e88ad579494d1726f1616f9c0 Mon Sep 17 00:00:00 2001 From: Benoit Alessandroni <benoit@happy-dev.fr> Date: Sat, 23 Nov 2019 18:35:39 +0100 Subject: [PATCH] Harmonizing the rendering of this feature --- src/includes/components/widgets.pug | 10 ++++----- src/includes/mentor/resources/detail.pug | 26 +++++++++++------------- 2 files changed, 17 insertions(+), 19 deletions(-) diff --git a/src/includes/components/widgets.pug b/src/includes/components/widgets.pug index 5e889adc..10016859 100644 --- a/src/includes/components/widgets.pug +++ b/src/includes/components/widgets.pug @@ -153,17 +153,17 @@ sib-widget(name="fake-dislike") template p 18 <i class="fas fa-thumbs-down"></i> -sib-widget(name="accordion-request-resource" ) +sib-widget(name="accordion-request-resource") template div h2 ${value} -sib-widget(name="cs-form-file-custom" ) +sib-widget(name="cs-form-file-custom") template label(for="preview_image") sib-form-file(upload-url=`${sdn}upload/` name="preview_image") -sib-widget(name="cs-display-twitter-button" ) +sib-widget(name="cs-display-twitter-button") template a.twitter-share-button( href=`https://twitter.com/intent/tweet?text=Check%20this%20resource%20from%20Coopstarter%20:%20\${value}` @@ -172,7 +172,7 @@ sib-widget(name="cs-display-twitter-button" ) ) i.fab.fa-twitter -sib-widget(name="cs-display-email-button" ) +sib-widget(name="cs-display-email-button") template a.email-share-button( href=`mailto:?subject=Coopstarter%20shared%20resource @@ -180,6 +180,6 @@ sib-widget(name="cs-display-email-button" ) ) i.far.fa-envelope -sib-widget(name="iframe-video-resource" ) +sib-widget(name="iframe-video-resource") template div ${value} diff --git a/src/includes/mentor/resources/detail.pug b/src/includes/mentor/resources/detail.pug index be3b63b7..cc1d8ac0 100644 --- a/src/includes/mentor/resources/detail.pug +++ b/src/includes/mentor/resources/detail.pug @@ -95,20 +95,18 @@ //- ) p SHARE - sib-display.email-link( - bind-resources - fields="@id" - widget-@id = 'cs-display-email-button' - ) - - //- sib-display#shareByTwitter.twitter-link.twshare( - //- bind-resources - //- fields="@id" - //- widget-@id = 'cs-display-twitter-button' - //- ) - script(async src="https://platform.twitter.com/widgets.js" charset="utf-8") - a(href="", target="_blank")#shareByTwitter.twshare.mdi.mdi-twitter - + sib-display.email-link( + bind-resources + fields="@id" + widget-@id = 'cs-display-email-button' + ) + + sib-display.twitter-link( + bind-resources + fields="@id" + widget-@id = 'cs-display-twitter-button' + ) + sib-display( bind-resources -- GitLab