Improve feedback from Prosody on subscriptions

@MattJ said on chat:

Except for a small fix I need to deploy, it answers 200 or 500 with some text explaining the problem Currently it is returning 200 + error text in some cases, instead of 500

For djangoldp-packages/djangoldp-notification!33 (merged) we would need detailed message for possible errors.

A 200+error can be accepted in case where Prosody faced 404.

@MattJ Could you estimate how much time you would need, if you face any questionable one, feel free to ask which behavior should be applied.

To restore correct status code and detailed messages on both the muc_admin and user endpoints, I estimate a couple of hours (including a quick Prosody update so I can take advantage of a new API that will help).

Let's do this

changed time estimate to 2h

mentioned in issue djangoldp-packages/djangoldp#281 (closed)

@MattJ As you started this yesterday, @calummackervoy may need some information from you there: djangoldp-packages/djangoldp-notification#27 (comment 38579)

@jbpasquier I have deployed this to the dev server for circle updates. I am running over the time estimate (currently at 2h9m - sorry, didn't notice).

There is probably another 1-2h of work to update the user update endpoint with the same improvements. That code is older, and should already consistently send errors already, but the error responses are currently in a different format to the circle update endpoint (plain text) and it doesn't take advantage of Prosody's new internal API for error management.

Should I work on updating the user endpoint to match, or move on? We can always revisit this later - user update has historically had fewer issues than circle update. However my personal preference would be to update it now so we keep consistency, and while all the changes I made to the circle endpoint are fresh in my mind.

Let's go for those 2h, updated the timesheet & estimation here.

added 2h 9m of time spent at 2020-10-20

changed time estimate to 4h

This is now deployed on the dev server. What's the best way of testing everything works as expected? @jbpasquier @calummackervoy

I also switched the partial update response code to 201.

@calummackervoy may be able to, from test1.

added 52m of time spent at 2020-10-21

Fixed some bugs discovered by Calum.

added 1h 9m of time spent at 2020-10-21

mentioned in issue applications/hubl#809 (closed)

mentioned in issue infra/prosody-modules#14 (closed)

closed