From 61c1e21bf182739b4f01ff49e983b03770d85256 Mon Sep 17 00:00:00 2001 From: ubermanu <e.vodor@gmail.com> Date: Fri, 19 Mar 2021 16:38:55 +0100 Subject: [PATCH 1/2] avoid an error if the picker is not initialized --- src/plugins/sib-emoji-picker.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/sib-emoji-picker.js b/src/plugins/sib-emoji-picker.js index b2f9270..1a243f6 100644 --- a/src/plugins/sib-emoji-picker.js +++ b/src/plugins/sib-emoji-picker.js @@ -42,8 +42,8 @@ converse.plugins.add('sib-emoji-picker', { setTimeout(() => { // Focus the search input afterwards const picker = this.querySelector('emoji-picker'); - picker?.shadowRoot.querySelector('.search')?.focus(); - }) + picker?.shadowRoot?.querySelector('.search')?.focus(); + }); }, }; -- GitLab From ae4d6debde7de263638afa5dd56e767ba17b4c4c Mon Sep 17 00:00:00 2001 From: ubermanu <e.vodor@gmail.com> Date: Fri, 19 Mar 2021 16:40:34 +0100 Subject: [PATCH 2/2] bugfix: register the picker element --- src/plugins/sib-emoji-picker.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/plugins/sib-emoji-picker.js b/src/plugins/sib-emoji-picker.js index 1a243f6..0c3da68 100644 --- a/src/plugins/sib-emoji-picker.js +++ b/src/plugins/sib-emoji-picker.js @@ -1,4 +1,4 @@ -import 'https://cdn.skypack.dev/emoji-picker-element'; +import { Picker } from 'https://cdn.skypack.dev/emoji-picker-element'; /** * Custom emoji picker. @@ -13,6 +13,10 @@ converse.plugins.add('sib-emoji-picker', { const _converse = this._converse; const { api, __ } = _converse; + // Register the picker element + api.elements.define('emoji-picker', Picker); + api.elements.register(); + /** * Force rendering of the emoji picker inside the dropdown. * Note: Without this mixin, the IndexedDB can't be loaded for some reason. -- GitLab