From 2d5abb4ad40c59185b3edcc6f3405c9c7b592c42 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste <bleme@pm.me>
Date: Mon, 25 Feb 2019 11:04:04 +0100
Subject: [PATCH] update: one test class per file
---
djangoldp/tests/runner.py | 3 +-
...ests.py => tests_anonymous_permissions.py} | 44 +++----------------
djangoldp/tests/tests_user_permissions.py | 40 +++++++++++++++++
3 files changed, 47 insertions(+), 40 deletions(-)
rename djangoldp/tests/{tests.py => tests_anonymous_permissions.py} (51%)
create mode 100644 djangoldp/tests/tests_user_permissions.py
diff --git a/djangoldp/tests/runner.py b/djangoldp/tests/runner.py
index af9839c8..70074c5b 100644
--- a/djangoldp/tests/runner.py
+++ b/djangoldp/tests/runner.py
@@ -27,7 +27,8 @@ test_runner = DiscoverRunner(verbosity=1)
failures = test_runner.run_tests([
'djangoldp.tests.tests_ldp_model',
'djangoldp.tests.tests_save',
- 'djangoldp.tests.tests',
+ 'djangoldp.tests.tests_user_permissions',
+ 'djangoldp.tests.tests_anonymous_permissions',
'djangoldp.tests.tests_update'])
if failures:
sys.exit(failures)
diff --git a/djangoldp/tests/tests.py b/djangoldp/tests/tests_anonymous_permissions.py
similarity index 51%
rename from djangoldp/tests/tests.py
rename to djangoldp/tests/tests_anonymous_permissions.py
index 049c288e..a8f4ee3f 100644
--- a/djangoldp/tests/tests.py
+++ b/djangoldp/tests/tests_anonymous_permissions.py
@@ -1,47 +1,15 @@
-from django.test import TestCase, Client, RequestFactory
+from django.contrib.auth.models import AnonymousUser
+from django.test import TestCase, RequestFactory
+from djangoldp.permissions import AnonymousReadOnly
from djangoldp.tests.models import JobOffer
from djangoldp.views import LDPViewSet
-from djangoldp.permissions import AnonymousReadOnly
-
-from django.contrib.auth.models import AnonymousUser, User
-
-
-class TestUserPermissions (TestCase):
- def setUp(self):
- self.factory = RequestFactory()
-# self.c = Client()
- self.user = User.objects.create_user(username='john', email='jlennon@beatles.com', password='glass onion')
-
- def tearDown(self):
- self.user.delete()
-
- def test_get_with_user(self):
- request = self.factory.get('/job-offers/')
- request.user = self.user
- my_view = LDPViewSet.as_view({'get': 'list'}, model=JobOffer, nested_fields=["skills"], permission_classes=[AnonymousReadOnly])
- response = my_view(request)
- self.assertEqual(response.status_code, 200)
-
- def test_request_options_create_with_user(self):
- request = self.factory.options('/job-offers/')
- request.user = self.user
- my_view = LDPViewSet.as_view({'options': 'create'}, model=JobOffer, nested_fields=["skills"], permission_classes=[AnonymousReadOnly])
- response = my_view(request)
- self.assertEqual(response.status_code, 201)
-
- def test_request_options_update_with_user(self):
- request = self.factory.options('/job-offers/')
- request.user = self.user
- my_view = LDPViewSet.as_view({'options': 'update'}, model=JobOffer, nested_fields=["skills"], permission_classes=[AnonymousReadOnly])
- response = my_view(request)
- self.assertEqual(response.status_code, 201)
-class TestAnonymousUserPermissions (TestCase):
+class TestAnonymousUserPermissions(TestCase):
def setUp(self):
self.factory = RequestFactory()
-# self.c = Client()
+ # self.c = Client()
self.user = AnonymousUser
def test_get_request_with_anonymousUser(self):
@@ -73,5 +41,3 @@ class TestAnonymousUserPermissions (TestCase):
permission_classes=[AnonymousReadOnly])
response = my_view(request)
self.assertEqual(response.status_code, 403)
-
-
diff --git a/djangoldp/tests/tests_user_permissions.py b/djangoldp/tests/tests_user_permissions.py
new file mode 100644
index 00000000..3ad30ddd
--- /dev/null
+++ b/djangoldp/tests/tests_user_permissions.py
@@ -0,0 +1,40 @@
+from django.contrib.auth.models import User
+from django.test import TestCase, RequestFactory
+
+from djangoldp.permissions import AnonymousReadOnly
+from djangoldp.tests.models import JobOffer
+from djangoldp.views import LDPViewSet
+
+
+class TestUserPermissions(TestCase):
+ def setUp(self):
+ self.factory = RequestFactory()
+ # self.c = Client()
+ self.user = User.objects.create_user(username='john', email='jlennon@beatles.com', password='glass onion')
+
+ def tearDown(self):
+ self.user.delete()
+
+ def test_get_with_user(self):
+ request = self.factory.get('/job-offers/')
+ request.user = self.user
+ my_view = LDPViewSet.as_view({'get': 'list'}, model=JobOffer, nested_fields=["skills"],
+ permission_classes=[AnonymousReadOnly])
+ response = my_view(request)
+ self.assertEqual(response.status_code, 200)
+
+ def test_request_options_create_with_user(self):
+ request = self.factory.options('/job-offers/')
+ request.user = self.user
+ my_view = LDPViewSet.as_view({'options': 'create'}, model=JobOffer, nested_fields=["skills"],
+ permission_classes=[AnonymousReadOnly])
+ response = my_view(request)
+ self.assertEqual(response.status_code, 201)
+
+ def test_request_options_update_with_user(self):
+ request = self.factory.options('/job-offers/')
+ request.user = self.user
+ my_view = LDPViewSet.as_view({'options': 'update'}, model=JobOffer, nested_fields=["skills"],
+ permission_classes=[AnonymousReadOnly])
+ response = my_view(request)
+ self.assertEqual(response.status_code, 201)
--
GitLab