diff --git a/djangoldp/permissions.py b/djangoldp/permissions.py
index eb18cd5abe7d42eb9fce1acbc59cb8f59ab9330c..888b563d6bc46db61fc6d376bad2e607de3d3088 100644
--- a/djangoldp/permissions.py
+++ b/djangoldp/permissions.py
@@ -3,7 +3,6 @@ from django.core.exceptions import PermissionDenied
class LDPPermissions(BasePermission):
-
"""
Default permissions
Anon: None
@@ -78,7 +77,6 @@ class LDPPermissions(BasePermission):
Access to containers
"""
perms = self.get_permissions(request.method, view.model)
-
# A bit tricky, but feels redondant to redeclarate perms_map
for perm in perms:
if not perm.split('.')[1].split('_')[0] in self.user_permissions(request.user, view.model):
diff --git a/djangoldp/tests/runner.py b/djangoldp/tests/runner.py
index 296716a1aeb175693462c90389eaa903b5905796..740948df72e9c93b96148e6343fb5717df2186a3 100644
--- a/djangoldp/tests/runner.py
+++ b/djangoldp/tests/runner.py
@@ -2,7 +2,8 @@ import django
import sys
from django.conf import settings
-settings.configure(DEBUG=True,
+settings.configure(DEBUG=False,
+ ALLOWED_HOSTS = ["*"],
DATABASES={
'default': {
'ENGINE': 'django.db.backends.sqlite3',
diff --git a/djangoldp/tests/tests_anonymous_permissions.py b/djangoldp/tests/tests_anonymous_permissions.py
index 4249c717a251a1e4fee12378d310ca273797fd23..adfb255ec8da827528b4848f412b3b95c8e97f24 100644
--- a/djangoldp/tests/tests_anonymous_permissions.py
+++ b/djangoldp/tests/tests_anonymous_permissions.py
@@ -1,8 +1,7 @@
import json
from django.test import TestCase
-from guardian.shortcuts import get_anonymous_user
-from rest_framework.test import APIRequestFactory
+from rest_framework.test import APIClient
from djangoldp.permissions import LDPPermissions
from djangoldp.tests.models import JobOffer
@@ -11,45 +10,29 @@ from djangoldp.views import LDPViewSet
class TestAnonymousUserPermissions(TestCase):
def setUp(self):
- self.factory = APIRequestFactory()
- self.user = get_anonymous_user()
- self.job = JobOffer.objects.create(title="job")
+ self.client = APIClient(enforce_csrf_checks=True)
+ self.job = JobOffer.objects.create(title="job", slug=1)
def test_get_request_for_anonymousUser(self):
- request = self.factory.get("/job-offers/")
- request.user = self.user
- my_view = LDPViewSet.as_view({'get': 'list'},
- model=JobOffer,
- nested_fields=["skills"])
- my_view.cls.permission_classes = [LDPPermissions]
-
- response = my_view(request)
+ response = self.client.get('/job-offers/')
self.assertEqual(response.status_code, 200)
- def test_post_request_for_anonymousUser(self):
- data = {'title': 'new idea'}
- request = self.factory.post('/job-offers/', json.dumps(data), content_type='application/ld+json')
- my_view = LDPViewSet.as_view({'post': 'create'}, model=JobOffer, nested_fields=["skills"])
- my_view.cls.permission_classes = [LDPPermissions]
+ def test_get_1_request_for_anonymousUser(self):
+ response = self.client.get('/job-offers/1/')
+ self.assertEqual(response.status_code, 200)
- response = my_view(request, pk=1)
+ def test_post_request_for_anonymousUser(self):
+ post = {'title': "job_created"}
+ response = self.client.post('/job-offers/', data=json.dumps(post), content_type='application/ld+json')
self.assertEqual(response.status_code, 403)
def test_put_request_for_anonymousUser(self):
- request = self.factory.put("/job-offers/")
- my_view = LDPViewSet.as_view({'put': 'update'},
- model=JobOffer,
- nested_fields=["skills"])
- my_view.cls.permission_classes = [LDPPermissions]
-
- response = my_view(request, pk=self.job.pk)
+ body = {'title':"job_updated"}
+ response = self.client.put('/job-offers/{}/'.format(self.job.pk), data=json.dumps(body),
+ content_type='application/ld+json')
self.assertEqual(response.status_code, 403)
-
+
def test_patch_request_for_anonymousUser(self):
- request = self.factory.patch("/job-offers/")
- my_view = LDPViewSet.as_view({'patch': 'partial_update'},
- model=JobOffer,
- nested_fields=["skills"])
- my_view.cls.permission_classes = [LDPPermissions]
- response = my_view(request, pk=self.job.pk)
+ response = self.client.patch('/job-offers/' + str(self.job.pk) + "/",
+ content_type='application/ld+json')
self.assertEqual(response.status_code, 403)
diff --git a/djangoldp/tests/tests_user_permissions.py b/djangoldp/tests/tests_user_permissions.py
index 7ab62104feea66f867a55f3b5c32c3879447d693..cd66a481941dfa416696bb9f30111404bb08b7aa 100644
--- a/djangoldp/tests/tests_user_permissions.py
+++ b/djangoldp/tests/tests_user_permissions.py
@@ -7,19 +7,22 @@ from djangoldp.views import LDPViewSet
import json
-
class TestUserPermissions(APITestCase):
def setUp(self):
user = User.objects.create_user(username='john', email='jlennon@beatles.com', password='glass onion')
self.client = APIClient(enforce_csrf_checks=True)
self.client.force_authenticate(user=user)
- self.job = JobOffer.objects.create(title="job")
+ self.job = JobOffer.objects.create(title="job", slug=1)
def test_get_for_authenticated_user(self):
response = self.client.get('/job-offers/')
self.assertEqual(response.status_code, 200)
+ def test_get_1_for_authenticated_user(self):
+ response = self.client.get('/job-offers/1/')
+ self.assertEqual(response.status_code, 200)
+
def test_post_request_for_authenticated_user(self):
post = {'title': "job_created"}
response = self.client.post('/job-offers/', data=json.dumps(post), content_type='application/ld+json')