From e6bb7b4fa0d612a222c6c0d3e14593915d09efb6 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Pasquier <contact@jbpasquier.eu>
Date: Tue, 22 Oct 2019 13:47:57 +0200
Subject: [PATCH] fix: permenent redirect
---
README.md | 6 ++++--
djangoldp/middleware.py | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/README.md b/README.md
index cbba9f6f..264545b7 100644
--- a/README.md
+++ b/README.md
@@ -267,9 +267,9 @@ INSTALLED_APPS = [
]
```
-## 302 on domain mismatch
+## 301 on domain mismatch
-To enable 302 redirection on domain mismatch, add `djangoldp.middleware.AllowOnlySiteUrl` on `MIDDLEWARE`
+To enable 301 redirection on domain mismatch, add `djangoldp.middleware.AllowOnlySiteUrl` on `MIDDLEWARE`
This ensure that your clients will use `SITE_URL` and avoid mismatch betwen url & the id of a resource/container
@@ -279,6 +279,8 @@ MIDDLEWARE = [
]
```
+Notice tht it'll redirect only HTTP 200 Code.
+
## License
Licence MIT
diff --git a/djangoldp/middleware.py b/djangoldp/middleware.py
index baef4e03..014b7b24 100644
--- a/djangoldp/middleware.py
+++ b/djangoldp/middleware.py
@@ -12,4 +12,4 @@ class AllowOnlySiteUrl:
if(is_safe_url(request.get_raw_uri(), allowed_hosts=settings.SITE_URL) or response.status_code != 200):
return response
else:
- return redirect('{}{}'.format(settings.SITE_URL, request.path))
+ return redirect('{}{}'.format(settings.SITE_URL, request.path), permanent=True)
--
GitLab