WIP: major: Django 2 upgrade
I've marked this as a WIP as it depends on the following MRs before we can test:
Merge request reports
Activity
added 7 commits
- ce855c6a - make newsletter in homepage not mandatory
- 3674aae1 - make newsletter in homepage not mandatory
- 61c0e35a - bugfix: enable upload of elected officials in app
- 88a8ceda - feature: add elected official position on a campaign
- 56f46a02 - rip: change import command for rip data
- a5df921e - Merge branch 'feature/template-revamp' into django-2-upgrade
- fb17007a - update: foreign keys define ON DELETE behaviour
Toggle commit listadded 2 commits
mentioned in merge request applications/risefor-front!2 (merged)
@Senza could you test the front-end with this branch please and then confirm that everything works?
to install this branch update your
packages.yml
to includerisefor_lobbying: git+https://git.startinblox.com/djangoldp-packages/risefor-lobbying.git@django-2-upgrade
and then run
sib install server
after following these steps when you run
pip show risefor_lobbying
it should output version
0.0.0
If everything is working in the front-end app then it's safe for us to merge :)
I also fixed the pipeline error in this MR- it was a problem
publish
stage of the Git pipeline, which means that commits being merged to master weren't being uploaded topip
(and so the latest versions won't be getting installed to users of rise-for). If you need this fix sooner than you can merge this MR let me knowheyhey @calummackervoy,
going to try the steps. I also pinged you on rocket chat as i was stuck on an djangoldp admin error while trying to merge locally this weekend
ok so installed
djangoldp-1.1.8
and updated djangoldp_conversation to V0.4 (versions before that i get the "on delete" errorI now have the following error
Exception in thread django-main-thread: Traceback (most recent call last): File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner self.run() File "/usr/lib/python3.6/threading.py", line 864, in run self._target(*self._args, **self._kwargs) File "/mnt/c/Users/maxim/Documents/taf/risefor/appli/federated/autochtones/env/lib/python3.6/site-packages/django/utils/autoreload.py", line 54, in wrapper fn(*args, **kwargs) File "/mnt/c/Users/maxim/Documents/taf/risefor/appli/federated/autochtones/env/lib/python3.6/site-packages/django/core/management/commands/runserver.py", line 117, in inner_run self.check(display_num_errors=True) File "/mnt/c/Users/maxim/Documents/taf/risefor/appli/federated/autochtones/env/lib/python3.6/site-packages/django/core/management/base.py", line 436, in check raise SystemCheckError(msg) django.core.management.base.SystemCheckError: SystemCheckError: System check identified some issues: ERRORS: djangoldp_account.Account: (auth.E005) The permission codenamed 'view_account' clashes with a builtin permission for model 'djangoldp_account.Account'. djangoldp_account.ChatProfile: (auth.E005) The permission codenamed 'view_chatprofile' clashes with a builtin permission for model 'djangoldp_account.ChatProfile'.
marked as a Work In Progress from 8d5669e9
@calummackervoy it was merged on another branch which i merged here
It was kind of a rough clean up due to all the different branches so it didn't go through a clean process but normally all your code is taken in :)
Edited by Maxime