Skip to content
Snippets Groups Projects

WIP: major: Django 2 upgrade

Closed Calum Mackervoy requested to merge django-2-upgrade into master
2 unresolved threads

I've marked this as a WIP as it depends on the following MRs before we can test:

Edited by Calum Mackervoy

Merge request reports

Pipeline #8791 failed

Pipeline failed for d2ce8a59 on django-2-upgrade

Closed by MaximeMaxime 4 years ago (Nov 22, 2020 3:15pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Calum Mackervoy added 7 commits

    added 7 commits

    • ce855c6a - make newsletter in homepage not mandatory
    • 3674aae1 - make newsletter in homepage not mandatory
    • 61c0e35a - bugfix: enable upload of elected officials in app
    • 88a8ceda - feature: add elected official position on a campaign
    • 56f46a02 - rip: change import command for rip data
    • a5df921e - Merge branch 'feature/template-revamp' into django-2-upgrade
    • fb17007a - update: foreign keys define ON DELETE behaviour

    Compare with previous version

  • Calum Mackervoy added 2 commits

    added 2 commits

    • 4bca81f9 - update: migrations for models
    • 13267383 - bugfix: updating test runner for Django 2.2

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Maxime unmarked as a Work In Progress

    unmarked as a Work In Progress

  • added 1 commit

    Compare with previous version

  • Calum Mackervoy changed title from Major: Django 2 upgrade to major: Django 2 upgrade

    changed title from Major: Django 2 upgrade to major: Django 2 upgrade

  • Calum Mackervoy changed the description

    changed the description

  • @Senza could you test the front-end with this branch please and then confirm that everything works?

    to install this branch update your packages.yml to include

    risefor_lobbying: git+https://git.startinblox.com/djangoldp-packages/risefor-lobbying.git@django-2-upgrade

    and then run

    sib install server

    after following these steps when you run

    pip show risefor_lobbying

    it should output version 0.0.0

    If everything is working in the front-end app then it's safe for us to merge :)

    I also fixed the pipeline error in this MR- it was a problem publish stage of the Git pipeline, which means that commits being merged to master weren't being uploaded to pip (and so the latest versions won't be getting installed to users of rise-for). If you need this fix sooner than you can merge this MR let me know

    • Maintainer

      heyhey @calummackervoy,

      going to try the steps. I also pinged you on rocket chat as i was stuck on an djangoldp admin error while trying to merge locally this weekend

    • Thanks, let me know!

      Rocket chat isn't working for me at the moment but I replied yesterday.. it looks like a problem with the DjangoLDP version you're running locally

      What version do you receive when you run pip show djangoldp?

    • Maintainer

      yeah it doesn't work for me either

      It shows

      Name: djangoldp
      Version: 0.6.40
    • ok so this is the cause of the error

      running pip install djangoldp>=1.0.0 should fix the problem?

    • Maintainer

      version 1.0.3 is good? the >= operator isn't understood on my end

    • Maintainer

      ok so installed djangoldp-1.1.8 and updated djangoldp_conversation to V0.4 (versions before that i get the "on delete" error

      I now have the following error

      Exception in thread django-main-thread:
      Traceback (most recent call last):
        File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner   
          self.run()
        File "/usr/lib/python3.6/threading.py", line 864, in run
          self._target(*self._args, **self._kwargs)
        File "/mnt/c/Users/maxim/Documents/taf/risefor/appli/federated/autochtones/env/lib/python3.6/site-packages/django/utils/autoreload.py", line 54, in wrapper
          fn(*args, **kwargs)
        File "/mnt/c/Users/maxim/Documents/taf/risefor/appli/federated/autochtones/env/lib/python3.6/site-packages/django/core/management/commands/runserver.py", line 117, in inner_run
          self.check(display_num_errors=True)
        File "/mnt/c/Users/maxim/Documents/taf/risefor/appli/federated/autochtones/env/lib/python3.6/site-packages/django/core/management/base.py", line 436, in check
          raise SystemCheckError(msg)
      django.core.management.base.SystemCheckError: SystemCheckError: System check identified some issues:
      
      ERRORS:
      djangoldp_account.Account: (auth.E005) The permission codenamed 'view_account' clashes with a builtin permission for model 'djangoldp_account.Account'.
      djangoldp_account.ChatProfile: (auth.E005) The permission codenamed 'view_chatprofile' clashes with a builtin permission for model 'djangoldp_account.ChatProfile'.
    • Maintainer

      So installed update djangoldp-account to 1.1.3 and it woooooooooooorks!

      Going to see if everything works

    • :tada:

      How did you get on?

    • Please register or sign in to reply
  • Maxime added 3 commits

    added 3 commits

    Compare with previous version

  • Maxime marked as a Work In Progress from 8d5669e9

    marked as a Work In Progress from 8d5669e9

  • closed

  • Why this was this closed instead of merged? Is risefor upgraded to Django 2.2?

Please register or sign in to reply
Loading