sib-router issueshttps://git.startinblox.com/framework/sib-router/-/issues2023-09-21T20:21:56+02:00https://git.startinblox.com/framework/sib-router/-/issues/85Previous page doesn't trigger the right events if the route is the same with ...2023-09-21T20:21:56+02:00Sylvain Le BonPrevious page doesn't trigger the right events if the route is the same with a different idhttps://git.startinblox.com/framework/sib-router/-/issues/84Router should allow multiple data-view for the same route2022-11-24T18:46:16+01:00Sylvain LehmannRouter should allow multiple data-view for the same routeHello,
I ran into an issue working on the needle projet.
I have this sort of configuration
```
┌──────────────┬────────────┐
│ Menu │ │
├──────────────┤ │
│ │ │
│ │ ...Hello,
I ran into an issue working on the needle projet.
I have this sort of configuration
```
┌──────────────┬────────────┐
│ Menu │ │
├──────────────┤ │
│ │ │
│ │ │
│ Panel 1 │ Panel 2 │
│ │ │
│ │ │
│ │ │
└──────────────┴────────────┘
```
The two panels contains widgets whitch depends on the link used on the menu.
The easiest way to to it should be to have a widget on each panel with a data-view attribute to chose the right one
The workarround i used is to use the data-view attribute only on panel1 and a custom element on panel 2, binded with the 'navigate' attribute from the router. But it should be cleaner to simply allow multiple data-view for the same route.
@balessan @manonbouhttps://git.startinblox.com/framework/sib-router/-/issues/83solid-analytics doesn't seems to work with an ID google type "G-xxx"2021-11-05T14:56:44+01:00Marjolaine Le Bonsolid-analytics doesn't seems to work with an ID google type "G-xxx"On the hubl landing page, i had this code :
```
<solid-analytics type="google" id="G-Q8MQH5X0BV"></solid-analytics>
```
the id is the correct one but nothing appears on my analytics page (here : https://analytics.google.com/analytics/we...On the hubl landing page, i had this code :
```
<solid-analytics type="google" id="G-Q8MQH5X0BV"></solid-analytics>
```
the id is the correct one but nothing appears on my analytics page (here : https://analytics.google.com/analytics/web)
Google seems to have change the system of analytics (ID were of the type "UA-xxx" before). Could it be the problem ?
@balessan https://git.startinblox.com/framework/sib-router/-/issues/81Add a warning if multiple routes with the same name in app2021-04-27T09:13:33+02:00Matthieu Fesseliermatthieu@startinblox.comAdd a warning if multiple routes with the same name in appWe should write a warning in the console if 2 routes with the same name are in the DOM.
This issue happens a lot, breaks the router, and is often complicated to debug.We should write a warning in the console if 2 routes with the same name are in the DOM.
This issue happens a lot, breaks the router, and is often complicated to debug.https://git.startinblox.com/framework/sib-router/-/issues/80sib-link target2021-02-17T20:18:45+01:00Clémentsib-link targetIs it possible to target blank (open in new tab) with sib-link?
@marjolaine needs it (https://git.startinblox.com/energie-partagee/sib-energiepartagee/issues/40)
What do you think @matthieu @balessan?Is it possible to target blank (open in new tab) with sib-link?
@marjolaine needs it (https://git.startinblox.com/energie-partagee/sib-energiepartagee/issues/40)
What do you think @matthieu @balessan?https://git.startinblox.com/framework/sib-router/-/issues/79Multi step form with router2021-01-06T09:11:51+01:00Antoine DupréMulti step form with routerIn [Sib-subscription](https://git.startinblox.com/components/sib-subscription/) I need to use a multi step form. I use custum widgets for each step with the desired inputs in ther content like this exemple :
```html
<!-- The router -->
<...In [Sib-subscription](https://git.startinblox.com/components/sib-subscription/) I need to use a multi step form. I use custum widgets for each step with the desired inputs in ther content like this exemple :
```html
<!-- The router -->
<solid-router
default-route="informations"
use-hash
class="nav-menu"
>
<solid-route name="informations" class="bloc-nav bloc-nav-1" active>
<div class="bloc-nav-number">1</div>
<div class="bloc-nav-text">Informations préalables</div>
</solid-route>
<solid-route name="personne" class="bloc-nav bn2">
<div class="bloc-nav-number">2</div>
<div class="bloc-nav-text">Saisi de vos informations personnelles</div>
</solid-route>
<solid-route name="acceptations" class="bloc-nav bn3" >
<div class="bloc-nav-number">3</div>
<div class="bloc-nav-text">Lecture et acceptation des documents précontractuels</div>
</solid-route>
...
</solid-router>
<!-- In parent form -->
<div class="all-steps">
<solid-form
class="first-form"
data-src="${sourceUrl}"
fields="screen2(personne), screen3(acceptations), screen4(partquantity)"
widget-personne="widget-step-personne"
widget-acceptations="widget-step-acceptations"
widget-partquantity="solid-display-partquantity"
>
</solid-form>
</div>
<!-- Exemples of widgets -->
<solid-widget name="widget-step-personne">
<template>
<div id="personne" data-view="personne" hidden>
<h2>Tu souhaites souscrire en tant que</h2>
<solid-form
data-holder
naked
data-src="${sourceUrl}"
fields="typemember, step2(identity(corporate(corponame, siret), gender, person(firstname, name, mandat), email, phone, birthday(birthdate, birthcity, birthcountry), address(numberaddress, streetaddress, zipcode, cityaddress, countryaddress), mailacceptance, changemail))"
widget-typemember="solid-form-radio" range-typemember="${typememberRange}"
...
></solid-form>
<solid-link next="acceptations" class="bloc-validation">Valider et continuer</solid-link>
</div>
</template>
</solid-widget>
<solid-widget name="widget-step-acceptations">
<template>
<div data-view="acceptations" hidden>
<h2>Validation des documents précontractuels</h2>
<solid-form
data-holder
naked
data-src="${sourceUrl}"
fields="informationvalidation, statutes, cavalidation, servicesattestation, beneficiciaireconfirmation"
widget-informationvalidation="solid-display-informationvalidation"
widget-statutes="solid-display-statutes"
widget-cavalidation="solid-form-checkbox"
widget-servicesattestation="solid-form-checkbox"
widget-beneficiciaireconfirmation="solid-form-checkbox"
></solid-form>
<solid-link next="montant" class="bloc-validation">Valider et continuer</solid-link>
</div>
</template>
</solid-widget>
```
But, when page is loaded, in js console I see this error:
```js
Uncaught Error: view "personne" is not in document
at HTMLElement.get view [as view] (solid-route.ts:29)
at HTMLElement.hide (solid-route.ts:128)
at HTMLElement.display (solid-router.ts:141)
at HTMLElement.init (solid-router.ts:73)
at solid-router.ts:15
```
The route links are fonctionnel but the init of router not. And if I have `#personne` in url the div with `data-view` attribute have no `active`attribute.
My first question is if it's a good use of router with widgets ?
And if router init is after widgets init ?https://git.startinblox.com/framework/sib-router/-/issues/76I would like to disable a route2021-05-27T09:58:02+02:00Alice PoggioliI would like to disable a routeI'm thinking about how to improve [sib-subscription](https://git.startinblox.com/components/sib-subscription/).
For this use case, I would like to disable routes while conditions I've chosen aren't fulfilled.
I imagine something like th...I'm thinking about how to improve [sib-subscription](https://git.startinblox.com/components/sib-subscription/).
For this use case, I would like to disable routes while conditions I've chosen aren't fulfilled.
I imagine something like this :
```html
<solid-router
default-route="preliminaryInformationForm"
route-prefix=""
use-hash
>
<solid-route name="preliminaryInformationForm" active>
Informations préalables</div>
</solid-route>
<solid-route name="personalInformationForm" disabled>
Saisi de vos informations personnelles</div>
</solid-route>
<solid-route name="acceptancePreContractualDocuments" disabled>
Lecture et acceptation des documents précontractuels</div>
</solid-route>
</solid-router>
```
In my dream, I imagine making it able by requesting it manually like this :
```js
//Prevent form submission and go to next step
let privacyPolicy = document.getElementById("privacy_policy")
privacyPolicy.addEventListener("submit", function (event) {
window.dispatchEvent(
new CustomEvent("requestNavigation", {
detail: { route: "personalInformationForm" }
})
);
event.preventDefault();
});
```
Is my dream possible ? :)https://git.startinblox.com/framework/sib-router/-/issues/72Integrate a default "Not Found" view2020-08-28T15:17:39+02:00Benoit Alessandronibenoit@startinblox.comIntegrate a default "Not Found" viewWhen a route does not exist we should return a default "not found" view.When a route does not exist we should return a default "not found" view.https://git.startinblox.com/framework/sib-router/-/issues/67Router should generate beautiful URLs2020-07-22T18:34:08+02:00Benoit Alessandronibenoit@startinblox.comRouter should generate beautiful URLsWe should find a way to use some kind of relatives URLs using compacted contexts.
But what happens in the case of a federation ?We should find a way to use some kind of relatives URLs using compacted contexts.
But what happens in the case of a federation ?https://git.startinblox.com/framework/sib-router/-/issues/59Set goods pratices and deeper examples with the router2020-04-01T15:58:33+02:00Alice PoggioliSet goods pratices and deeper examples with the routerI think It will be good to have "goods practices" on where we should put a router and how to manage the potential sub-router. Some draws would be nice to understand best uses quickly.I think It will be good to have "goods practices" on where we should put a router and how to manage the potential sub-router. Some draws would be nice to understand best uses quickly.https://git.startinblox.com/framework/sib-router/-/issues/69Sib-Router Context: Feature Request2020-08-03T17:00:22+02:00Calum MackervoySib-Router Context: Feature Request**Context(s)**
I have one form `create-customer` which is a child form of `edit-project` and `create-project`. On `create-customer` save, I want to redirect to its parent form, but without the context of where I came from, how do I know ...**Context(s)**
I have one form `create-customer` which is a child form of `edit-project` and `create-project`. On `create-customer` save, I want to redirect to its parent form, but without the context of where I came from, how do I know where to redirect? (I solved this problem by duplicating the form)
There are other situations where a `sib-link` should go "back" without it being known at runtime where "back" is. Apps commonly have timelines where I can visit any point of my history:
![Screenshot_2020-02-19_at_13.19.08](/uploads/f4438d18ef9eeb088ed3ffd06845e4f8/Screenshot_2020-02-19_at_13.19.08.png)
**Suggested Solution**
The router holds a navigation "stack" - an array of pages which represents the history of pages visited. It can be navigated by using `push` and `pop` on the stack. This is the solution used in Ionic: https://ionicframework.com/docs/v3/api/navigation/NavController/https://git.startinblox.com/framework/sib-router/-/issues/68Matomo - Implement UserId when logged in with webid-oidc2020-08-04T20:20:51+02:00Ghost UserMatomo - Implement UserId when logged in with webid-oidcWe would like to be able to track a particular user via her email address across multiple devices and browsers.
Is it possible to implement this in `sib-router` with Matomo?
https://matomo.org/docs/user-id/
That would rock big time an...We would like to be able to track a particular user via her email address across multiple devices and browsers.
Is it possible to implement this in `sib-router` with Matomo?
https://matomo.org/docs/user-id/
That would rock big time and help us understand better what our user base is doing and how to improve our product.
@rachel @jbpasquier @balessanClémentClémenthttps://git.startinblox.com/framework/sib-router/-/issues/70sib-link should handle active class2020-08-05T12:04:26+02:00Jean-Baptiste Pasquiersib-link should handle active classAfter sib-core#558 I've updated our left menu on FNK App like this: https://git.happy-dev.fr/startinblox/applications/sib-app/blob/circle-perf-fix/src/menu-left.pug#L58-76
It gives us pretty faster loading for circles.
Problem: Here th...After sib-core#558 I've updated our left menu on FNK App like this: https://git.happy-dev.fr/startinblox/applications/sib-app/blob/circle-perf-fix/src/menu-left.pug#L58-76
It gives us pretty faster loading for circles.
Problem: Here the `next` is not working. https://git.happy-dev.fr/startinblox/applications/sib-app/blob/circle-perf-fix/src/menu-left.pug#L66
Edit: The solution is that the `sib-link` must automatically have an active class when its route is activated.https://git.startinblox.com/framework/sib-router/-/issues/56link on sections2019-11-28T12:51:47+01:00Clémentlink on sectionsIs that possible to have links to sections of pages, (like `next="technology/#contact"` or `next="home/#contact"`Is that possible to have links to sections of pages, (like `next="technology/#contact"` or `next="home/#contact"`https://git.startinblox.com/framework/sib-router/-/issues/55Documentation does not explain how I draw a component when hitting a route2020-09-09T10:28:03+02:00ClémentDocumentation does not explain how I draw a component when hitting a routeCurrently, the documentation explains how to declare a router, a new route and a link to go to the route, but not how to render a page when hitting that route.Currently, the documentation explains how to declare a router, a new route and a link to go to the route, but not how to render a page when hitting that route.https://git.startinblox.com/framework/sib-router/-/issues/54Active still buggy2022-04-07T14:06:44+02:00ClémentActive still buggyActive on nested-routers is buggy.
* Go to `https://test1.startinblox.com/circle/@https~@~_~_api~!test1~!startinblox~!com~_circles~_1~_/circle-information`
* You'll see "Test Circle" on left menu & "Information" on right menu highlighte...Active on nested-routers is buggy.
* Go to `https://test1.startinblox.com/circle/@https~@~_~_api~!test1~!startinblox~!com~_circles~_1~_/circle-information`
* You'll see "Test Circle" on left menu & "Information" on right menu highlighted.
* Click on "Chat" then on "Information"
* You're on the same page as before, but "Test Circle" on left menu isn't highlighted.
(You may need an account on test-paris to check that. Feel free to ask for one)https://git.startinblox.com/framework/sib-router/-/issues/53Allow an id-prefix for more friendly sib-route2019-10-25T17:16:30+02:00ClémentAllow an id-prefix for more friendly sib-routeOn nested routers, it route can be pretty repetitive.
Let say I have these nested routers:
* Page (#page, use-id)
* Page Information (#page-information)
* Page Edition (#page-edition)
My URL will look like this: `http://localhost...On nested routers, it route can be pretty repetitive.
Let say I have these nested routers:
* Page (#page, use-id)
* Page Information (#page-information)
* Page Edition (#page-edition)
My URL will look like this: `http://localhost:3000/page/page-information/page-edition/@https~@~_~_localhost:8000~_pages~_1~_`
I would love to have something like `<sib-route id-prefix="page-" name="edition">Edition</sib-route>` matching `#page-edition` & render it like this: `http://localhost:3000/page/information/edition/@https~@~_~_localhost:8000~_pages~_1~_`https://git.startinblox.com/framework/sib-router/-/issues/51close the modal when clicking on the overlay2019-10-14T14:03:23+02:00Clémentclose the modal when clicking on the overlay@Marjolaine wants it@Marjolaine wants ithttps://git.startinblox.com/framework/sib-router/-/issues/48RequestNavigate boolean for refresh resource2019-10-03T12:09:13+02:00ClémentRequestNavigate boolean for refresh resourceAs see with @alexandre & @clement
On RequestNavigate, I need a boolean to trigger the refresh of the data-src or not.
Usage case : On sib-chat, I click on a notification, it triggers a RequestNavigate. If it's the same resource as the...As see with @alexandre & @clement
On RequestNavigate, I need a boolean to trigger the refresh of the data-src or not.
Usage case : On sib-chat, I click on a notification, it triggers a RequestNavigate. If it's the same resource as the one I'm already on, I don't want to refresh it.https://git.startinblox.com/framework/sib-router/-/issues/47Create a wildcard route2020-09-17T19:43:06+02:00ClémentCreate a wildcard routeWe need a way to handle some kind of wildcard route that will use the resource @type to redirect properly the user.
On sib-app, needed for:
* Chat notification link on emails
* Link to user profile from chatWe need a way to handle some kind of wildcard route that will use the resource @type to redirect properly the user.
On sib-app, needed for:
* Chat notification link on emails
* Link to user profile from chat