Non members of circles should not be able to chat

When I open a circle of which I'm not a member, I can type a message. I should have to join first before being able to participate to the conversation.

XMPP implementation only purpose "semi-anonymous" or "member-only" MUC.

So we can only disable text-area on client-side with some JS. But any visitor can re-enable it and speak freely if so.

Or we can use a member only way (That we tend to go), but it'll work like that : You join. You see what's on. You're free to speak/do what you want. (May be added later : You can leave.)

Or we can create a super XEP & implement it on prosody and converse... But I'm pretty sure that's not the best way for now.

Thanks for the overview analysis. @alexandre what do you think?

Take also a look there, we may want to mutualise reflexion for similars problems as they can be related.

https://git.happy-dev.fr/startinblox/components/sib-chat/issues/91

assigned to @jbpasquier

By Alexandre on 2019-09-04T10:03:34 (imported from GitLab project)

changed milestone to %Circles

By Alexandre on 2019-09-04T10:03:43 (imported from GitLab project)

I believe we should have a discussion on that topic with @jcbrand and @MattJ. They'll know better how to implement this use case into the XMPP world.

For the record, I did start the conversation on sibchat_conversejs@muc.asso-fare.fr

By Alexandre on 2019-09-04T10:13:42 (imported from GitLab project)

added 1 deleted label

Sounds like you just want a moderated room, which defaults non-members to the "visitor" role (defined in XEP-0045), and this prevents them from being able to speak in the room.

This is controlled through the per-room config (the same one that controls who can see JIDs, etc. that we discussed recently). To default new rooms to this behaviour you can set muc_room_default_moderated = true

How Converse reacts in a moderated room when you are not a member, I don't know - replacing the input box with some info and a "Request membership" button or something would be nice. See this relevant PR in converse.js also.

By Matthew Wild on 2019-09-05T16:05:35 (imported from GitLab project)

@MattJ : Thank you very much for your quick response.

@pierredelacroix : clear for you ?

By Alexandre on 2019-09-05T17:32:28 (imported from GitLab project)

assigned to @pierredelacroix and unassigned @jbpasquier

By Alexandre on 2019-09-05T17:32:55 (imported from GitLab project)

removed 1 deleted label

assigned to @MattJ and unassigned @pierredelacroix

By Alexandre on 2019-10-16T15:21:54 (imported from GitLab project)

mentioned in merge request !77 (merged)

changed milestone to %10

By Alexandre on 2020-01-08T08:24:28 (imported from GitLab project)

Today, we hide the Circles of which I'm not a member.

The problem will occur when somebody shares with me a link of a Circle I'm not a member of. Let's consider it a edge case for now and tackle it in a few months once the problem becomes real.

By Alexandre on 2020-01-08T08:25:32 (imported from GitLab project)

changed milestone to %Circles MVP

The edge case described by @alexandre is covered by https://git.happy-dev.fr/startinblox/applications/sib-app/issues/301 so I'm closing this issue.

closed

Totally fine with me.

Just to stress it out one more time: the behaviour presented by Sylvain here sounds more in line with Sophie's mock-ups and what we agreed regarding Circles characteristics than the 404 error presented in #301 (closed). Maybe having it in mind is enough. Maybe closing #301 (closed) and keeping this one instead does the job as well.

By Alexandre on 2020-03-14T07:35:48 (imported from GitLab project)

changed milestone to %Circles part I