Clicking anywhere on the app should close the top right hand menu

Once I opened the top right hand menu, it remains open until I explicitly close it. This is not what we want.

changed milestone to %Projects part I

By Alexandre on 2019-11-14T22:25:15 (imported from GitLab project)

mentioned in merge request !79 (merged)

I thought about whether the user control should be in its own component, but I'm not so sure.. opened MR for this !79 (merged)

closed

added 1 deleted label

I like the idea of a user control component.

I don't know how we could handle his generation as it may depends on presence of other components: With or without sib-oidc, and then which links should be generated on.

I'm not sure to understand why this was not added in sib-notifications. Any specific reason?

The user control component is not a child of the sib-notifications component, should it be?

I probably didn't get what the user control component was. Do you have more details?

@calummackervoy: Just so you know: the process is normally: you tag the issue To be tested once the feature is deployed on https://test-paris.happy-dev.fr/, and assign it to me. I close it if the test is successful. It is best to avoid losing track of an issue.

It works well anyway. Thanks!

By Alexandre on 2019-11-20T22:50:57 (imported from GitLab project)

@calummackervoy: If that is not a pain, I would also close it if Esc is pressed. Not a big deal if it is a pain though, but it is a good UX practice. All the apps I can think of do it.

By Alexandre on 2019-11-20T22:50:57 (imported from GitLab project)

reopened

removed 1 deleted label

mentioned in merge request !82 (merged)

done this in MR !82 (merged)

sorry about the slow reply to this, the 'component' is here (it's actually a details tag): https://git.happy-dev.fr/startinblox/applications/sib-app/blob/master/src/header.pug#L17

a few lines above is the sib-notifications component

Is this supposed to be deployed on https://test-paris.happy-dev.fr ?

By Alexandre on 2019-11-26T09:22:17 (imported from GitLab project)

It is now. ;)

added 1 deleted label

assigned to @alexandre and unassigned @calummackervoy

closed