[Circle's information page] Administrator status not written

The administrator of a Circle should be tagged accordingly on the Circle's information page.

This is what is represented on the mock-ups:

changed milestone to %Projects part I

By Alexandre on 2019-11-17T14:04:48 (imported from GitLab project)

@jbpasquier is the data in the screenshot above stored in Django currently?

if not I think the "Administrator" role should be on the CircleMember model (https://api.test-paris.happy-dev.fr/admin/djangoldp_circle/circlemember/81/change/)

I suppose Newbie could be dynamically calculated from "Date joined", but there are also "Capitaine" and other roles which I think would be obtained from user.groups? (https://api.test-paris.happy-dev.fr/admin/djangoldp_account/ldpuser/37/change/) so it's probably simpler to add "Newbie" if the user has no other groups

Pulling data from two sources like this might complicate how the front-end accesses it, perhaps a property circle_member.roles could simplify it? e.g.

@property
def roles:
    result = list(str(g) for g in self.user.groups.all())
    if self.is_admin:
        result.append("Administrator")
    return result

My proposed system above does miss out how the front-end knows the source (to colour yellow or blue, unless it's just hardcoded to colour "Administrator" blue)

Currently, we don't have administrator on. https://git.happy-dev.fr/startinblox/applications/sib-app/issues/278

As they require more configuration on permissions than we can actually set.

By the way, the Role is already showed on test-paris, Administrator isn't a role, even if you can see it on the same place.

For now, as we use the Owner field for permissions, I believe you could simply put "Administrator" to the member that is also the Owner of.

mentioned in issue #278 (closed)

I guess owner and administrator are the same thing, right?

nah because there can only be one owner but there can be multiple administrators https://projects.invisionapp.com/share/3POVGBKAQD8#/screens/384813505

the owner will always be an admin though I think

the difficulty with this issue front-end is that the team-members are displayed using a sib-display of team.. as such the widget template-team doesn't have access to the owner property (on circle object)

I think it would be cleaner if the back-end could return a set of user.roles concatenated as user.groups with user.is_owner (property to check if the user is the owner of the circle).. this will also be easily changeable for issue #278 (closed) (swapping is_owner with is_admin) @jbpasquier what do you think?

I made some custom attributes on JS that watch for widget population that you could use here.

page-circle-profile.pug

    sib-display.block(
      bind-resources
      fields='team'

      multiple-team=''
      action-team='team'
      widget-team='circle-team-template'
      hd-inherit-widgets
    )

hd-circle-team.pug

sib-widget(name='circle-team-template')
  template
    sib-display(
      data-src="${await value}"
      fields='account.picture, sup(name, circle, groups), sub(profile.city)'

      widget-account.picture='hd-user-avatar'
      widget-groups='hd-user-groups'
      value-circle='${src}'
      widget-circle='my-superbe-owner-widget'

      multiple-groups=''
      hd-inherit-widgets
    )

my-superbe-owner-widget.pug

sib-widget(name='my-superbe-owner-widget')
  template
    sib-display(
      data-src="${value}"
      fields='owner'
      search-fields='owner"
      search-widget-owner='sib-form-hidden'
      search-value-owner=""
      hd-inherit-user-id="search-value-owner"
      hd-inherit-widgets
    )

With this, you'll have my-superbe-owner-widget displayed only if current user is the owner of the circle.

For information:

• hd-inherit-widgets: Trigger the recursive script
• hd-inherit-user-id="search-value-user": Will put the user id on the target field.

changed the description

By Alexandre on 2019-11-18T14:36:30 (imported from GitLab project)

@jbpasquier: Where can I see what those two do?

• hd-inherit-widgets: Trigger the recursive script
• hd-inherit-user-id="search-value-user": Will put the user id on the target field.

By Alexandre on 2019-11-18T14:44:14 (imported from GitLab project)

There: https://git.happy-dev.fr/startinblox/applications/sib-app/blob/circle-css/src/scripts/index.js#L1-43

By the way, if one day we put a developers doc on sib-app, I can add few infos on.

This is working in branch circle-admin-role.. changed the sib-display to work with circle-members rather than team-members.. sorry @gaelleM @Mulletto_00 this has destroyed your beautiful CSS!

Also it depends on unreleased changes to DjangoLDP (#302 (closed)), for the CircleMember.is_admin field.. for now you can test the CSS by changing this line (26) in circle-team.pug

template ${await value ? "Administrator" : ""}

to

template Administrator

@calummackervoy I'll try to fix it this WE :)

By Gaëlle Morin on 2019-11-27T15:08:41 (imported from GitLab project)

@calummackervoy As https://git.happy-dev.fr/startinblox/applications/sib-app/issues/278 is on a later run, we need to put a solution here that'll use owner field.

@gaelleM Wait a fix before editing here. ;)

@calummackervoy, @jbpasquier: Why are there no time estimation on this issue?

By Alexandre on 2019-11-26T08:38:22 (imported from GitLab project)

To be honest I think it would be less work to get permissions finished on #278 (closed)

@calummackervoy Could you try to estimate time needed to finish & polish the #278 (closed) ?

I need your help with it (posted some questions on that issue) but I think a couple of hours would be conservative? I'm not sure what the inheritance permission was about, though

Keep me posted

By Alexandre on 2019-11-26T14:03:45 (imported from GitLab project)

I've set-up something similar for edit-project (using project-members) in branch project-info-page & it's nuked the styling there too