Do not display "null" on no information
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Jean-Baptiste Pasquier changed milestone to %Projects part I
changed milestone to %Projects part I
- Maintainer
The way to solve this would be to make the
elements for the client details conditional. This is currently not supported by sib-core: https://git.happy-dev.fr/startinblox/framework/sib-core/issues/546... in the meantime should I make the "null" labels disappear, without losing the icons/headings themselves?
I experimented with my hack from that issue
await value.name ? "<li ...></li>" : ""
but couldn't get it working
- Author Owner
This way should works, as here: https://git.happy-dev.fr/startinblox/applications/sib-app/blob/master/src/templates/hd-user-avatar.pug#L2
About hidings, I guess icons must be hidden, but I don't know for headings.
@sophie What's your advice on this?
- Developer
@jbpasquier yes keep the title contact but hide the icons. I am thinking it might be good to have the client's name and email mandatory to create a project
- Calum Mackervoy mentioned in merge request !96 (merged)
mentioned in merge request !96 (merged)
- Maintainer
MR open for making first_name and email required fields: https://git.happy-dev.fr/startinblox/djangoldp-packages/djangoldp-project/merge_requests/27
MR open for this issue: !96 (merged)
- Jean-Baptiste Pasquier closed
closed