Resolve "Comments on job offers"

Closes #139 (closed)

changed milestone to %Projects part I

By Gaëlle Morin on 2019-06-12T08:05:58 (imported from GitLab project)

added Doing label

changed target branch from master to staging

By Gaëlle Morin on 2019-06-12T08:06:21 (imported from GitLab project)

assigned to @gaelleM

By Gaëlle Morin on 2019-06-12T08:06:21 (imported from GitLab project)

I'm having some problems:

• According to the wireframe, I must display the first name and not the first name + the surname.
• The avatar display does not work => src(unknown).
• According to the wireframe, I do not need a submit button to create a new comment. Actually, I need it otherwise it starts a new line.
• The comment field will be different because I can not add a placeholder, there are no smileys, the resize will be visible because it is a textfield.
• To response to another person, the wireframe suggests using a @. It does not work, I have to use the response button.

By Gaëlle Morin on 2019-06-17T09:59:41 (imported from GitLab project)

added 1 deleted label

Thaks @gaelleM I guess it's a good start.

@matthieu what do you think about these?

added 1 deleted label

added 19 commits

• 176b9c58...248f7776 - 17 commits from branch staging
• ad2033b1 - wip
• 4ae77ede - simple css edition

Compare with previous version

By Gaëlle Morin on 2019-06-17T12:56:18 (imported from GitLab project)

According to the wireframe, I must display the first name and not the first name + the surname.

As we said before, I use the rdfs:label here. Can it be the first_name of the user?

The avatar display does not work => src(unknown).

Probably the same than this issue: startinblox/components/sib-conversation#7 . I need to work on this

According to the wireframe, I do not need a submit button to create a new comment. Actually, I need it otherwise it starts a new line.

Should we provide an option to have one version with textarea + submit button and one with input + submit on enter?

The comment field will be different because I can not add a placeholder, there are no smileys, the resize will be visible because it is a textfield.

Same here, should we provide an option to choose between label and placeholder? For the smileys, I guess we have to include an external library

To response to another person, the wireframe suggests using a @. It does not work, I have to use the response button.

So we need to be able to tag people and send a notification? We can precise this idea if it's needed.

@sylvain What do you think?

Does Matthew have to develop new things? It might take some time, isn't it? Or do I adapt by trying to stick to the wireframes (results not guaranteed ). Or do you have another solution?

By Gaëlle Morin on 2019-06-27T08:26:45 (imported from GitLab project)

No you I think you just have to add a context to map rdfs:label on get_full_name

@sophie I see that on this wireframe (https://invis.io/3POVGBKAQD8#/328712388_NEW_PROJECTS), there is no button to post a comment.

I conclude that as soon as the user presses the "enter" key, the message is posted. But what happens if the user wants to write a message on several lines?

It seems more intuitive to me that the "enter" key allows you to go to the line and a "submit" button allows you to post a message.

What do you think about that?

By Gaëlle Morin on 2019-07-05T10:19:06 (imported from GitLab project)

@gaelleM I did the same as the actual rocket chat but yes you can add a button, I agree with what you said.

Thank you Sophie :)

By Gaëlle Morin on 2019-07-08T09:13:41 (imported from GitLab project)

added 19 commits

• 4ae77ede...cf561e45 - 16 commits from branch staging
• ecba2ca6 - simple css edition
• c1a94c79 - wip
• 02c4b105 - js ok

Compare with previous version

By Gaëlle Morin on 2019-07-11T15:32:14 (imported from GitLab project)

added 2 commits

• faf006c0 - comments are ok
• c1114388 - comments are ok

Compare with previous version

By Gaëlle Morin on 2019-07-12T13:52:10 (imported from GitLab project)

added 1 commit

• 2b1f64e4 - comments are ok

Compare with previous version

By Gaëlle Morin on 2019-07-12T14:16:05 (imported from GitLab project)

added 1 commit

• b70dbfb4 - simple css edition

Compare with previous version

By Gaëlle Morin on 2019-07-12T14:59:37 (imported from GitLab project)

added 1 commit

• 27854606 - feature: sib-conversation added

Compare with previous version

By Gaëlle Morin on 2019-07-12T16:03:02 (imported from GitLab project)