Can't create a circle anymore

added 1 deleted label

changed the description

@balessan This is some serious shit, and @jbpasquier is to be considered "digitally dead" until a miracle happens.

Who else can we ask to intervene?

Ping @alexbourlier I just tested and cannot confirm this bug (you can find a SIB - Benoit Test circle in the list). I properly got a 201 created right after the POST.

As far as I know there were no recent deployments.

That's a good news if I'm the only one affected.

@calummackervoy Do you reproduce the bug or you also don't?

You did not enter a description, could that have a link ?

No, if it was a problem I would have an error message in return, no?

@balessan OK you're correct. Thanks!

@jbpasquier WTF?

@alexbourlier there is also the possibility that the core team did not properly implement the support of the required-* on the richtext widget. If you can confirm, let me know.

Actually, it's true that it's working with a description, and the required may not be properly implemented. However, the server should return an error and not stay in a pending state forever. I think we have 2 issues here

I also think so

Yes definitely, there is something broken. But the server part needs investigation by the project team I would say.

At least to get the logs.

At the moment, the project team is... dead, as JB has no internet. If you have somebody in your CTO bagpack that can take this on, he or she is most welcome

@calummackervoy for the djangoldp part and @plup for the logging/infra part I would say.

But still, it's a project, there is supposed to be a project team to deal with that.

Facing weird things here.

I tried this on test3:

Admin -> Create a circle
Title: test
Headline: test
Press save

Loader appeared, no POST made at all.

I added a description. Pressed save. It works.

Notice that we don't have any required-description here.

@balessan @matthieu Do you need anything else? As far as I saw, no request at all so I don't really know what should I debug further?

I don't know if it's specific to Firefox, but doing the same, on my side I have a POST request made, but waiting in pending indefinitely, and a OPTIONS after the POST, which resolves with a 200

Firefox here, two different behavior on the same browser?

I tried on community too, got the same behavior as my upper comment #966 (comment 50884)

So, I created a local server and tried it there. It looks that my Firefox does not show the request at all, but there is a POST with an empty body made.

No I tried with Chrome but I knew you were on Firefox :)

Oh, yeah, right. :-)

Empty body for you too so?

No I have this:

{
  "status":"Public",
  "linebreak":"",
  "name":"test1",
  "subtitle":"test1",
  "description":"\n",
  "help":"",
  "@context": {
    "@vocab":"http://happy-dev.fr/owl/#",
    "rdf":"http://www.w3.org/1999/02/22-rdf-syntax-ns#",
    "rdfs":"http://www.w3.org/2000/01/rdf-schema#",
    "ldp":"http://www.w3.org/ns/ldp#",
    "foaf":"http://xmlns.com/foaf/0.1/",
    "name":"rdfs:label",
    "acl":"http://www.w3.org/ns/auth/acl#",
    "permissions":"acl:accessControl",
    "mode":"acl:mode",
    "geo":"http://www.w3.org/2003/01/geo/wgs84_pos#",
    "lat":"geo:lat",
    "lng":"geo:long",
    "inbox":"http://happy-dev.fr/owl/#inbox",
    "object":"http://happy-dev.fr/owl/#object",
    "author":"http://happy-dev.fr/owl/#author",
    "account":"http://happy-dev.fr/owl/#account",
    "jabberID":"foaf:jabberID",
    "picture":"foaf:depiction"
  }
}

Let me know if I can help

@matthieu Weird, that I'm not able to get the same behavior. Anyway.

From what you have, I'm sure that the issue is that the description is "\n" instead of empty or absent.

There may be some kind of trimming on server side which can lead to the next issue. @balessan @calummackervoy

Next step?

I replicated this in a unit test and the issue is that description isn't defined in the context (or sent as a URL), and when this happens PyLD actually just strips it out of the request, so it's never makes it to LDPSerializer

I sent the same request with the context changed as follows and it passed:

body = {
          ...
          "description":"\n",
          ...
          "@context": {
            ...
            "description":"rdfs:comment"
          }
        }

I'm surprised the server hangs when it hits this, it doesn't respond 500 ? In my test it threw an exception sqlite3.IntegrityError: NOT NULL constraint failed: djangoldp_circle_circle.description

P.S. the fields in Circle shouldn't be NOT NULL (djangoldp-packages/djangoldp#224) - I included changes to the models in the MR djangoldp-packages/djangoldp-circle!40 (merged). I set default='' instead of null=True so it shouldn't impact any existing code

Issue open for the thrown IntegrityError: djangoldp-packages/djangoldp#359

and when this happens PyLD actually just strips it out of the request

@calummackervoy that looks weird to me because we are often not defining every property in the context.

I'm surprised the server hangs when it hits this, it doesn't respond 500 ?

ON my side, it just hangs indeed

that looks weird to me because we are often not defining every property in the context.

@balessan I'm certain that it does this, but it's a bit of a black box for me how it does it - like it seems completely fine with me passing a property which doesn't exist on the HD ontology, but for other properties having @vocab: 'happy-dev.fr/owl/#' seems to be enough... A priori it could be reading some properties from the vocabulary, and if they're not explicitly defined on it then it's permissive with any URL given explicitly ? We'd need to spend some time debugging PyLD to know for sure (or ask them)

it just hangs indeed

@alexbourlier could you please reproduce and confirm if in the Network/Réseau panel of your browser's dev tools you have a response from the server of 500 on the request or if it's waiting for the server to send one ? I assume it's waiting but just to make sure it's a backend problem

@calummackervoy My screenshot in the issue doesn't answer your question already?

ah it does indeed thanks :) moving this to a new issue djangoldp-packages/djangoldp#360 (closed)

Mate @calummackervoy would you say it works properly now here to create circle or there's some issues remaining ?

Ah sorry I missed something with this: djangoldp-packages/djangoldp-circle!41 (merged)

I didn't realise that Django default does not apply when the field is explicitly set to None. I added null=True because it was the easiest way to solve it

This fix just stops the 500 though, the bug will now be "when I create a circle the description is not set correctly" - see my previous comment #966 (comment 51050)

How are we moving forward with that bug ?

Discussions opened for things serverside which made this bug less conspicuous than it should have been (just opened a new one in this list):