Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
K
knowledgebase-front
Manage
Activity
Members
Labels
Plan
Issues
19
Issue boards
Milestones
Wiki
Code
Merge requests
3
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Applications
Knowledge Base
knowledgebase-front
Commits
9a0def61
Commit
9a0def61
authored
5 years ago
by
Benoit Alessandroni
Browse files
Options
Downloads
Patches
Plain Diff
Patching the review form submission and adding confirmation
parent
3a614cb3
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/includes/mentor/resources/validate.pug
+18
-7
18 additions, 7 deletions
src/includes/mentor/resources/validate.pug
src/scripts/coopstarter.js
+3
-3
3 additions, 3 deletions
src/scripts/coopstarter.js
with
21 additions
and
10 deletions
src/includes/mentor/resources/validate.pug
+
18
−
7
View file @
9a0def61
...
...
@@ -3,6 +3,7 @@ include ../../components/widgets
sib-router
sib-route(name='improvement-dialog')
sib-route(name='refusal-dialog')
sib-route(name='review-submission-confirmation')
.block_log.block_creat_count
sib-display#detail-view(
...
...
@@ -74,37 +75,47 @@ sib-router
sib-form#validation-form(
data-src=`${endpoints.reviews}`
fields='resource, status',
widget-resource='sib-form-hidden'
fields='resource
s
, status',
widget-resource
s
='sib-form-hidden'
widget-status='sib-form-hidden'
value-status='validated'
submit-button='Validate'
next='review-submission-confirmation'
)
dialog#refusal-dialog
h2.title_lead Report as inappropriate
sib-form#refusal-dialog-form(
data-src=`${endpoints.reviews}`
fields='comment, resource, status',
fields='comment, resource
s
, status',
label-comment='Explain reasons of refusal*'
widget-comment='sib-form-textarea'
widget-resource='sib-form-hidden'
widget-resource
s
='sib-form-hidden'
widget-status='sib-form-hidden'
value-status='inappropriate'
submit-button='Send ->'
next='review-submission-confirmation'
)
dialog#improvement-dialog
h2.title_lead Suggest improvement
sib-form#improvement-dialog-form(
data-src=`${endpoints.reviews}`
fields='comment, resource, status',
fields='comment, resource
s
, status',
label-comment='Explain improvement required*'
widget-comment='sib-form-textarea'
widget-resource='sib-form-hidden'
widget-resource
s
='sib-form-hidden'
widget-status='sib-form-hidden'
value-status='to_improve'
submit-button='Send ->'
)
\ No newline at end of file
next='review-submission-confirmation'
)
dialog#review-submission-confirmation
h2.title_lead_avenir Thanks for your review
p.flex The submitter of the resource will now receive a notification of your review.
p.flex He will then be able to patch and send back the resource to validation
p.flex
sib-link(next='mentor-resource-list', class='button_base') Back to dashboard
\ No newline at end of file
This diff is collapsed.
Click to expand it.
src/scripts/coopstarter.js
+
3
−
3
View file @
9a0def61
...
...
@@ -26,9 +26,9 @@ jQuery(document).ready(function($) {
const
detail
=
document
.
getElementById
(
"
detail-view
"
);
detail
.
addEventListener
(
"
populate
"
,
event
=>
{
linkDatasetToField
(
detail
,
'
validation-form
'
,
'
resource
'
);
linkDatasetToField
(
detail
,
'
refusal-dialog-form
'
,
'
resource
'
);
linkDatasetToField
(
detail
,
'
improvement-dialog-form
'
,
'
resource
'
);
linkDatasetToField
(
detail
,
'
validation-form
'
,
'
resource
s
'
);
linkDatasetToField
(
detail
,
'
refusal-dialog-form
'
,
'
resource
s
'
);
linkDatasetToField
(
detail
,
'
improvement-dialog-form
'
,
'
resource
s
'
);
});
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment