Feature/review conversation
11 unresolved threads
11 unresolved threads
issue ongoing --> Blocking conversation form submit when resource form is invalid
Merge request reports
Activity
Filter activity
added 14 commits
-
98992e75...624df839 - 13 commits from branch
master
- a4698f5f - Merge branch 'master' into feature/review-conversation
-
98992e75...624df839 - 13 commits from branch
- npm-debug.log 0 → 100644
1 0 info it worked if it ends with ok @Senza : we do not want to add that file to the repository.
127 ) 128 //class reviewConversation used in Js to hide element 129 p.reviewConversation="Explain the changes you have brought before submitting them" @Senza : you should use the translations here.
147 152 p 148 153 i.fas.fa-times 149 154 h2.title_lead=`${data.SuggestImprovement}` 155 156 //- sib-conversation#improvement_dialog_form( @Senza : please remove commented content.
270 270 * Manage the report broken links hidden form 271 271 */ 272 272 function fillReportBrokenLinkForm(event, userWhoSubmitReport, formBrokenLink) { 273 /* @Senza : Same thing, useless to keep the commented content inside the repository.
506 508 }); 507 509 } 508 510 511 /********* 512 * Feature: Comment review conversation 513 *********/ 514 //event listener on conversation modules loading 515 document.addEventListener("DOMContentLoaded", () => { @Senza : I did not test, but I am not sure that this DomContentLoaded is needed.
506 508 }); 507 509 } 508 510 511 /********* 512 * Feature: Comment review conversation 513 *********/ 514 //event listener on conversation modules loading 515 document.addEventListener("DOMContentLoaded", () => { 516 517 //on nav check if the resource is validated 518 //hide the review conversations && display normal submit button 519 520 document.addEventListener("navigate", (e) => { 521 522 if (["contributor-resource-edit","contributor-resource-validate"].includes(e.detail.route)) { 523 console.log("navigate"); @Senza : useless console.log
513 *********/ 514 //event listener on conversation modules loading 515 document.addEventListener("DOMContentLoaded", () => { 516 517 //on nav check if the resource is validated 518 //hide the review conversations && display normal submit button 519 520 document.addEventListener("navigate", (e) => { 521 522 if (["contributor-resource-edit","contributor-resource-validate"].includes(e.detail.route)) { 523 console.log("navigate"); 524 525 setTimeout(() => { 526 checkResourceValidity(e); 527 removeEmptyConversation(); 528 @Senza : useless line breaks
520 document.addEventListener("navigate", (e) => { 521 522 if (["contributor-resource-edit","contributor-resource-validate"].includes(e.detail.route)) { 523 console.log("navigate"); 524 525 setTimeout(() => { 526 checkResourceValidity(e); 527 removeEmptyConversation(); 528 529 530 }, 500); 531 532 setTimeout(() => { 533 //make sure 534 var conversationModule = document.querySelectorAll( "#" + e.detail.route + " solid-conversation")[1]; 535 console.log("target of event",conversationModule); @Senza : I will stop repeating here, but please remove the console.logs before pushing something.
564 else if (resourceValidateFormSubmit){ 565 resourceValidateFormSubmit.click() 566 } 567 else{ 568 console.log("Script should not launch",conversationModules); 569 } 570 571 }); 572 }, 8000); 573 }; 574 }); 575 576 577 578 //hide element on edit form if there's no feedback 579 /* @Senza : same remarks about commented lines than above.
616 reviewConversations.forEach(reviewConversation => { 617 console.log("convo to display",reviewConversation); 618 reviewConversation.style.display = "block"; 619 }); 620 //display form submit 621 let reviewFormSubmit = document.querySelector( "#" + e.detail.route + " #resource_edition_form input[type=submit]"); 622 reviewFormSubmit.style.display = "none"; 623 } 624 } 625 /** 626 * On edit forms 627 * If no feedback, hide section 628 */ 629 function removeEmptyConversation() { 630 /* 631 //select the content in first conversation's @Senza : I think that one should not be commented actually.