Merge request reports
Activity
mentioned in issue #9 (moved)
mentioned in issue #137 (closed)
mentioned in issue #47 (closed)
assigned to @jbpasquier
Tested on https://test3.startinblox.com
At first, could you please split your MR? I would like to deliver all of those features on separate versions. Also please make branches directly on the repository and use our commits convention. https://docs.startinblox.com/import_documentation/devops/commit_message_convention.html
4 parts here:
RAI
Still does not works properly.
- After page load, if I don't open the room, I'll never get any unread on it.
- If I logout, then login (or use another browser), I don't get any unreads on channel that I didn't read during my session.
These two are the same issues as last weeks. Still we've an evolution, as if I don't logout and that my session didn't expire, I'll keep the unread on menu - Even if I read them on another device.
I don't understand why we struggle here. Is it something working this way on native fullscreen converse too? If you open your converse and had message on MUC after you've quit your last session you have no unread notification at all?
Logs:
- On the Admin account, Canal 2 is open, never opened Canal 1, receiving an unread on Canal 1 from Awesome. I see no notification. https://bin.jbpasquier.eu/?7c4629b315cb5eb1#5uSDXeAexCCjo3UD1eqEYTvm56DpX38JcrWzCGPHShbj
- On Admin account, opened Canal 1 then goes to Canal 2, received a message from Awesome on Canal 1 got a notification. (works fine, but only if I joined) https://bin.jbpasquier.eu/?8892bbefd573e248#6EzrcsJFqq7Fk3pSs1SfBnA1uGopCTiU3CoqkDCfR4Gg
- Same as above, but I logged out & in and opened Canal 2. I get no notification on Canal 1 - had never read it. https://bin.jbpasquier.eu/?aad9f3fd2026b2f9#9E1P93k7qjhQg9DvWsohe46DJwY1sYLzyjcdEStvbafT
Reactions
This one needs a separation from the one above, looks a bit weird, I feels that we'll have some UX needs here. Using the same frame as the one for smilies is pretty far from the button on large screen, when with an "unread message bar", the icon is aligned with the bar and overall UI looks like it's missing information like: Who reacted?
List of emojis & Recent ones
Pretty cool. But I lost the recent ones after a logout/login and they seems to be paired to the device.
Meet Jit.si
Does not works on my side. Using Firefox, no visual feedback. Log on the one who asked to call: https://bin.jbpasquier.eu/?e3f4c7b645f3b250#J938YBdiF2qR4FfxvRpTn2JxTGMWfLyoEkegtSGNXzMv On the one who is called, only a line telling
ReferenceError: Notification is not definedconverse-rai.js:191:22.added 1 commit
- eec51b68 - send displayed marker when messages are seen by user otherwise send received
assigned to @deleolajide and unassigned @jbpasquier