Remove Singleton & Embedded in favor of Fullscreen with plugin

Alternative to https://git.happy-dev.fr/startinblox/components/sib-chat/issues/127

Implication;

• Remove Singleton & Embedded mode to allow converse to keep connection to already opened rooms (Standard behavior)
• Add fullscreen mode, with a custom plugin to disable the controlbox that contains Contact and Chatroom views UI.

Pros (vs. headless):

• Cost much less time

Cons (vs. headless):

• Less integration than headless. Every custom things that we want must go on custom plugins.

Other pros (vs. current system, also valid for headless):

• Better perfs than current system (No need to leave/join rooms on returning)

mentioned in issue #127 (closed)

By Jean-Baptiste Pasquier on 2020-02-19T16:30:37 (imported from GitLab project)

changed the description

By Jean-Baptiste Pasquier on 2020-02-19T16:30:46 (imported from GitLab project)

assigned to @jbpasquier and unassigned @dele

By Jean-Baptiste Pasquier on 2020-02-19T16:30:51 (imported from GitLab project)

This solution was chosen over https://git.happy-dev.fr/startinblox/components/sib-chat/issues/127

Steps:

• Change converse integration to use fullscreen mode
• Remove chat close on changeChat
• CSS Integration - Resize window and remove useless UI parts.

By Jean-Baptiste Pasquier on 2020-02-19T16:32:11 (imported from GitLab project)

@gaelleM @rachel I've done first step. You can see Converse in fullscreen on http://test-paris.happy-dev.fr/ and http://test-nantes.happy-dev.fr/

It's ready for CSS integration.

@gaelleM To proceed:

• Clone sib-app, install as usual
• Use the test-paris config.json
• Make a lib directory on dist folder
• Clone sib-chat (branch fullscreen) to path/to (Or another path :))
• On this lib directory, ln -s ../path/to/sib-chat ./sib-chat

You can make your changes on themes/converse-hd.css as before.

Please sync with @rachel for what to hide and what to keep.

test-paris config.json

{
  "xmpp": "https://jabber.happy-dev.fr/http-bind/",
  "authority": "https://api.test-paris.happy-dev.fr/",
  "clientName": "Happy Dev Paris - Test",
  "clientLogo": "https://cdn.happy-dev.fr/logos/paris.png",
  "clientLogoHeight": "72px",
  "authorityName": "test-paris",
  "publicDirectory": false,
  "libLocal": false,
  "endpoints": {
    "get": {
      "customers": "https://api.test-paris.happy-dev.fr/customers/",
      "businessproviders": "https://api.test-paris.happy-dev.fr/businessproviders/",
      "circles": "https://api.test-paris.happy-dev.fr/sources/circles",
      "projects": "https://api.test-paris.happy-dev.fr/sources/projects/",
      "skills": "https://api.test-paris.happy-dev.fr/skills/",
      "users": "https://api.test-paris.happy-dev.fr/sources/users/"
    },
    "post": {
      "customers": "https://api.test-paris.happy-dev.fr/customers/",
      "businessproviders": "https://api.test-paris.happy-dev.fr/businessproviders/",
      "circles": "https://api.test-paris.happy-dev.fr/circles/",
      "projects": "https://api.test-paris.happy-dev.fr/projects/",
      "skills": "https://api.test-paris.happy-dev.fr/skills/",
      "users": "https://api.test-paris.happy-dev.fr/users/"
    }
  }
}

By Jean-Baptiste Pasquier on 2020-02-20T15:09:07 (imported from GitLab project)

assigned to @gaelleM and unassigned @jbpasquier

By Jean-Baptiste Pasquier on 2020-02-19T16:35:34 (imported from GitLab project)

@gaelleM some notes for our call on Monday so I don't forget anything:

• we need to hide the second right bar menu. Participants are already in the main right bar menu, so we don't loose any info by hidding it. I'm unsure about the need to keep somewhere. I would just hide it for the moment.

• The left menu is disappearing if I try to MP someone. I'm not sure this is a CSS only issue.

• When I hover on one of my messages, I see two options : edit and delete The bin/trash icon is not working. Apparently it is something that was hidden before? In that case, we should hide it again.

By Rachel on 2020-02-21T11:58:32 (imported from GitLab project)

When I hover on one of my messages, I see two options : edit and delete The bin/trash icon is not working. Apparently it is something that was hidden before? In that case, we should hide it again.

The pencil enables selective message correction and the bin/trash icon is for a new Converse 6.x feature which allows for message retraction.

so my conclusion on this is that I should open an issue for the bin icon which does not work or @dele are you saying this will be fixed in the next Converse upgrade?

@gaelleM as discussed, the 3 fix needed here are:

1. Hide the additional right side bar:

2. Fix the unfolded right menu (note that this happens when you are on a circle, but not a project):

3. Check the fact that the left side menu is disappearing if you try to MP someone or if you reproduce number 2 (unfolded right side menu).

By Rachel on 2020-02-24T13:53:30 (imported from GitLab project)

added 1 deleted label

or @dele are you saying this will be fixed in the next Converse upgrade?

It should be be working in SiB App. In my Converse client, it displays this

Please try again. If you do not get this dialog, then raise an issue.

I can confirm that we never get any dialog on any of our instance.

But, maybe, the dialog is hidden by CSS ? @gaelleM ?

By Jean-Baptiste Pasquier on 2020-02-24T19:00:37 (imported from GitLab project)

mentioned in merge request !22 (merged)

By Jean-Baptiste Pasquier on 2020-02-25T19:04:10 (imported from GitLab project)

closed via merge request !22 (merged)

By Jean-Baptiste Pasquier on 2020-02-25T23:27:03 (imported from GitLab project)

mentioned in commit 97430972

By Jean-Baptiste Pasquier on 2020-02-25T23:27:03 (imported from GitLab project)