Profile picture
Profile pictures would need to be displayed next to user's name.
Activity
changed milestone to %v0.1
By Alexandre on 2018-03-21T17:20:01 (imported from GitLab project)
mentioned in issue #23 (closed)
By JC Brand on 2018-04-24T17:47:05 (imported from GitLab project)
- Fetch user vCards in MUC
- Update mockups markup to show avatars in messages
- Update templates and JavaScript to show avatars in messages
- Update markup to only show one avatar per collection of adjacent messages
By JC Brand on 2018-05-02T14:42:11 (imported from GitLab project)
Edited by Clément-
Mockup showing messages with avatars.
The left and right sidebars (and header etc.) are of course not relevant to the Happy-dev component.
By JC Brand on 2018-04-26T14:08:29 (imported from GitLab project)
Edited by Clément -
Indeed
Sylvain Le Bon gitlab@happy-dev.fr schrieb am Fr., 27. Apr. 2018, 11:41:
By Alexandre on 2018-04-28T16:35:03 (imported from GitLab project)
-
I've made a branch containing UI work for showing user avatars to master.
If you update the webcomponent then you should be getting the new changes. When in doubt, remove
node_modules/conversejsand then runnpm installto make sure you get the latest version.In the interest of moving forward I've removed the last TODO list item in this ticket, which was to show a fallback image if no avatar image is set. Looking at your Rocket.chat instance, all users have avatars, so can we assume that this will be the case going forward, at least for now?
What's still needed for this ticket is to fetch the user avatar from the server, I'm currently working on that and expect to be finished with that by the end of tomorrow.
By JC Brand on 2018-04-30T15:28:29 (imported from GitLab project)
-
Thank you for this update JC. Too bad this took that long but it is good you took the time to do it properly, I prefer to have a realiable component than to play it cheap.
I fully agree with you regarding the default avatar thing. Let's assume everyone has one for now and later on, for the alpha or beta version of the application we will get back to it.
Good luck with the rest of the roadmap
By Alexandre on 2018-04-30T18:08:52 (imported from GitLab project)
-
This is done now.
One unfortunate limitation that XMPP servers have, which I found out while working on this issue, is that they can only return a user's avatar in a channel if that user is currently in the channel.
EDIT: There might be a way to work around this, by making all channels non-anonymous (so that user JIDs are available) and then maintaining member lists for all channels, but I think that's out of scope for this ticket, seeing as it already took a lot of time, and I think you guys should first try things out and decide whether it would be worth spending more time on avatars or not.
By JC Brand on 2018-05-02T14:54:51 (imported from GitLab project)
Edited by Clément