Clean code and separate concerns
4 unresolved threads
4 unresolved threads
- Installed Prettier with conf
- Format code
- Moved all the plugins outside of the main component
- Moved Deferred into a utils file
- Renamed plugins with correct prefixes
Note:
-
converse-xxx
plugins are related to converse itself (adds feature or fixes a bug) -
sib-xxx
plugins are related to the chat component itself
Merge request reports
Activity
Filter activity
added 4 commits
-
441696e1...001c8fea - 3 commits from branch
beta
- dd34f2b2 - Merge branch 'beta' into 'cleaning'
-
441696e1...001c8fea - 3 commits from branch
57 57 "sass": "^1.32.5" 58 58 }, 59 59 "devDependencies": { 60 "prettier": "^2.2.1", changed this line in version 3 of the diff
- .prettierrc 0 → 100644
1 { 2 "arrowParens": "avoid", 3 "trailingComma": "es5", 4 "tabWidth": 4, changed this line in version 3 of the diff
- src/plugins/sib-chat-navigation.js 0 → 100644
1 /** 2 * Register a new event to move the converse element 3 * into another component. 4 */ 5 converse.plugins.add('sib-chat-navigation', { 6 initialize() { 7 const _converse = this._converse; 8 const { api } = _converse; 9 10 window.addEventListener('sib-change-chat', async ev => { changed this line in version 4 of the diff
96 }, contactsURL); 97 } 98 } 99 }, 100); 100 } 101 await converse_sib.connected_deferred; 102 103 window.dispatchEvent(new CustomEvent('sib-change-chat', { 104 detail: { 105 jid: this.jid, 106 is_groupchat: await this.resource.jabberRoom, 107 root: this.element.shadowRoot, 108 }, 109 })); 110 111 window.dispatchEvent(new CustomEvent('read', { changed this line in version 4 of the diff
mentioned in commit de90f7f8
Please register or sign in to reply