Conversejs master switch
Solves #149 (closed)
Merge request reports
Activity
assigned to @XaviFP
@XaviFP I edited your MR with a WIP, link to the issue, and targeted beta instead of master.
added 2 commits
-
@XaviFP Status?
@jbpasquier I found the issue with the message options dropdown menu. Did a fix but I have only been able to test in Firefox as I'm getting the infite auth loop in Chrome. So once I'm able to test this last thing in Chrome/Chromium CSS is the only part left.
-
Ok, fine. I'll try to push the core team for improvement here.
Could you open issues about those CSS parts? Describing what's wrong and how to reach that state, I'll see with @gaelleM to provide your MR to fix that.
-
Sorry for the delay.
So, this is how it looks like in production:
And this is how it looks like with latest Conversejs version locally:
As long as I can see it hasn't changed that much, consisting the changes in the scrollbar width, the separator bar height and the color.
For the record, changing the variable name
--chatroom-head-colorto--chatroom-head-bg-colorinindex.cssfixes the color issue.And adding the variable
--chatroom-message-input-border-top: 0px solid var(--chatroom-head-bg-color);fixes the separator bar heigth.With those changes applied it looks like this:
So the background color of the icons should be slightly darker.
As for the scrollbar I still need to check.
Also worth of mention is that the attach file icon is linked to the availability of the feature. So if it's not desired, it could be hidden by CSS. As it is right now, the code doesn't have a toggle to switch visibility of the icon.
-
This is not supported anymore? https://git.startinblox.com/components/solid-xmpp-chat/blob/master/src/solid-xmpp-chat.js#L279
-
I haven't seen any visibility toggle in the code and the current available documentation doesn't seem to have it as an explicit option either: https://conversejs.org/docs/html/configuration.html#visible-toolbar-buttons
added 12 commits
-
26665743...8b02ea9e - 3 commits from branch
beta - c35a9f01 - substitute converse and it's minified version to use converse master version
- a44debe8 - switch to unminified conversejs file to ease debugging
- 0c67604b - update Conversejs to latest master
- cd11c710 - update settings and API calls according to latest Conversejs
- f423c975 - update deprecated API call
- 12fa0da5 - show one-to-one chats
- 7be8f3bd - bump Conversejs
- cb2391e0 - hide send button
- 3d3a93c6 - prevent message actions dropdown from closing after event retargeting
Toggle commit list-
26665743...8b02ea9e - 3 commits from branch
mentioned in commit 038d6a29