fix: reworked the parameter fetching in packages

djangoldp/conf/global_settings.py

@@ -37,7 +37,7 @@ ALLOWED_HOSTS = []
 TIME_ZONE = 'America/Chicago'
 
 # If you set this to True, Django will use timezone-aware datetimes.
-USE_TZ = False
+USE_TZ = True
 
 # Language code for this installation. All choices can be found here:
 # http://www.i18nguy.com/unicode/language-identifiers.html

djangoldp/conf/settings.py

@@ -52,28 +52,36 @@ class LDPSettings(object):
         """Set a dict has current configuration."""
         self._config = value
 
-    def register(self, _list, name):
+    def fetch(self, attributes):
         """
-        Explore packages looking for a list of params to register within the server configuration.
-        It extends it with found elements and doesn't manage duplications or collisions.
-        All elements are returned.
+        Explore packages looking for a list of attributes within the server configuration.
+        It returns all elements found and doesn't manage duplications or collisions.
         """
 
+        attr = []
         for pkg in self.DJANGOLDP_PACKAGES:
             try:
                 # import from an installed package
                 mod = import_module(f'{pkg}.djangoldp_settings')
-                _list.extend(getattr(mod, name))
-                logger.debug(f'{name} found in installed package {pkg}')
-            except (ModuleNotFoundError, NameError):
+                logger.debug(f'Settings found for {pkg} in a installed package')
+            except (ModuleNotFoundError):
                 try:
                     # import from a local packages in a subfolder (same name the template is built this way)
                     mod = import_module(f'{pkg}.{pkg}.djangoldp_settings')
-                    _list.extend(getattr(mod, name))
-                    logger.debug(f'{name} found in local package {pkg}')
-                except (ModuleNotFoundError, NameError):
-                    logger.info(f'No {name} found for package {pkg}')
-                    pass
+                    logger.debug(f'Settings found for {pkg} in a local package')
+                except (ModuleNotFoundError):
+                    logger.debug(f'No settings found for {pkg}')
+                    break
+
+            # looking for the attribute list in the module
+            try:
+                attr.extend(getattr(mod, attributes))
+                logger.debug(f'{attributes} found in local package {pkg}')
+            except (NameError):
+                logger.info(f'No {attributes} found for package {pkg}')
+                pass
+
+        return attr
 
     @property
     def DJANGOLDP_PACKAGES(self):
@@ -95,7 +103,7 @@ class LDPSettings(object):
         apps.extend(self.DJANGOLDP_PACKAGES)
 
         # add apps referenced in packages
-        self.register(apps, 'INSTALLED_APPS')
+        apps.extend(self.fetch('INSTALLED_APPS'))
 
         return apps
 
@@ -110,7 +118,7 @@ class LDPSettings(object):
         middlewares = getattr(global_settings, 'MIDDLEWARE')
 
         # explore packages looking for middleware to reference
-        self.register(middlewares, 'MIDDLEWARE')
+        middlewares.extend(self.fetch('MIDDLEWARE'))
 
         return middlewares