Automatically add urls for users

It seems User urls are not generated automatically. I think it should be the case.

pig @alexandre

The issue is :

• When a route is not "djangoldp.Models" dependent it's not automatically generated.

More precisely, the file urls.py on packages is not automatically loaded.

Actually, we use this code on the server sources :

for package in settings.DJANGOLDP_PACKAGES:
    try:
        urlpatterns.append(url(r'^', include('{}.urls'.format(package))))
    except ModuleNotFoundError:
        pass

It may be move to djangoldp.urls.py

By Jean-Baptiste on 2019-04-16T08:22:51 (imported from GitLab project)

created merge request djangoldp-account!10 (closed) to address this issue

By Jean-Baptiste on 2019-04-16T08:23:32 (imported from GitLab project)

mentioned in merge request djangoldp-account!10 (closed)

By Jean-Baptiste on 2019-04-16T08:23:33 (imported from GitLab project)

moved from djangoldp-account#9 (closed)

By Jean-Baptiste on 2019-04-16T08:24:44 (imported from GitLab project)

created merge request !56 (merged) to address this issue

By Jean-Baptiste on 2019-04-16T08:25:01 (imported from GitLab project)

mentioned in merge request !56 (merged)

By Jean-Baptiste on 2019-04-16T08:25:02 (imported from GitLab project)

Is there a specific reason for not adding automatically the urls of the models not inheriting from djangoldp.Model?

@jbpasquier I finally add it on djangoldp, so no reason to put it in sib-manager

@sylvain Less flexibility. Now if you want to put /users/ in myserver/my_specific_path/users, you can't. Route are defined in modules and only in modules. So if 2 modules define the same route, developers are unable to fix it without merge-requesting the module

By Jean-Baptiste on 2019-04-16T08:34:30 (imported from GitLab project)

My opinion is that users who want more flexibility can just remove djangoldp.urls and define their owns. They're not our main target.

Now the situation today is that users building a Sib app have an error because of User not having a url. They have to add a urls.py file just for User. And they're all in this situation. I think it's not really developer friendly.

closed via merge request !56 (merged)

By Jean-Baptiste on 2019-04-16T09:19:44 (imported from GitLab project)

mentioned in commit d0449836

By Jean-Baptiste on 2019-04-16T09:19:44 (imported from GitLab project)

From sib-manager, DjangoLDP now call DjangoLDP self urls.py.

RecursionError: maximum recursion depth exceeded.

reopened

The "server" module nor djangoldp module must not be in settings.DJANGOLDP_PACKAGES

By Jean-Baptiste on 2019-04-16T12:24:48 (imported from GitLab project)

Got it! Thanks.

sib!5

closed

reopened

@bleme have you seen this comment? What do you think?

The situation today is that users building a Sib app have an error because of User not having a url. They have to add a urls.py file just for User. And they're all in this situation. I think it's not really developer friendly.