Update sib:source structure

Today, we have source objects with the following structure:

{
  "@id": "",
  "@type": "ldp:Container",
  "ldp:contains": [
    {
      "federation": "users",
      "container": "https://api.test-nantes.happy-dev.fr/users/",
      "@type": "sib:source",
    },
    {
      "federation": "users",
      "container": "https://api.test-paris.happy-dev.fr/users/",
      "@type": "sib:source",
    }
  ]
}

To support query-ldflex, we need to have an @id property for each resource. Ideally, we would like to get sources like this:

{
  "@id": "",
  "@type": "ldp:Container",
  "ldp:contains": [
    {
      "@id": "https://api.test-nantes.happy-dev.fr/users/",
      "@type": "ldp:Container",
    },
    {
      "@id": "https://api.test-paris.happy-dev.fr/users/",
      "@type": "ldp:Container",
    }
  ]
}

created merge request !97 (merged) to address this issue

By Jean-Baptiste on 2019-09-05T08:49:53 (imported from GitLab project)

mentioned in merge request !97 (merged)

By Jean-Baptiste on 2019-09-05T08:49:54 (imported from GitLab project)

closed via merge request !97 (merged)

By Jean-Baptiste on 2019-09-05T09:15:54 (imported from GitLab project)

mentioned in commit 8470b6f6

By Jean-Baptiste on 2019-09-05T09:15:54 (imported from GitLab project)

I'm not sure how to add a source but with the new version I get an object like this:

{
  "@id": "http://127.0.0.1:8000/sources/users/",
  "@type": "ldp:Container",
  "ldp:contains": [
    {
      "federation": "users",
      "container": "http://localhost:8000/users/",
      "@id": "http://127.0.0.1:8000/sources/users/",
      "@type": "sib:source",
    }
  ],
}

I expected this:

{
  "@id": "http://127.0.0.1:8000/sources/users/",
  "@type": "ldp:Container",
  "ldp:contains": [
    {
      "federation": "users",
      "@id": "http://localhost:8000/users/",
      "@type": "ldp:Container",
    }
  ],
}

reopened

created merge request !98 (merged) to address this issue

By Jean-Baptiste on 2019-09-05T15:30:00 (imported from GitLab project)

mentioned in merge request !98 (merged)

By Jean-Baptiste on 2019-09-05T15:30:01 (imported from GitLab project)

This is not logic. I knew that something had to go wrong with LDPSource.

It may be solved with the work I'm doing on https://git.happy-dev.fr/startinblox/djangoldp-packages/djangoldp/issues/167

By Jean-Baptiste on 2019-09-05T15:51:38 (imported from GitLab project)

What do you mean? You don't understand why it doesn't work?

The implementation of LDPSource is just a very bad implementation. Need to refactor it once We can create an object containing a list of LDPUrlField (eg external resources)

btw, I made an hack to make it work the way you want it. But it's a hack

By Jean-Baptiste on 2019-09-05T16:05:26 (imported from GitLab project)

closed via merge request !98 (merged)

By Jean-Baptiste on 2019-09-05T16:08:09 (imported from GitLab project)

mentioned in commit f4508b46

By Jean-Baptiste on 2019-09-05T16:08:10 (imported from GitLab project)

@matthieu You will have to :

• get the last djangoldp version
• run a ./manage.py migrate
• recreate all your sources. use the field 'id' it's replacing 'container'

By Jean-Baptiste on 2019-09-05T16:10:12 (imported from GitLab project)

mentioned in issue #183 (closed)

mentioned in issue framework/sib-core#634 (closed)