Skip to content
Snippets Groups Projects

Resolve "Need to restart server to access created ldp source"

Merged Ghost User requested to merge 73-reload-source into master

Closes #73 (closed)

Edited by Ghost User

Merge request reports

Checking pipeline status.

Merged by avatar (Mar 27, 2025 11:03pm UTC)

Merge details

Pipeline #1032 passed

Pipeline passed for cd9a45ee on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added 1 deleted label

    added 1 deleted label

  • Ghost User added 1 commit

    added 1 commit

    • a67f2ed6 - update: reload source on new source

    Compare with previous version

    By Jean-Baptiste on 2019-08-03T14:46:20 (imported from GitLab project)

  • Ghost User unmarked as a Work In Progress

    unmarked as a Work In Progress

    By Jean-Baptiste on 2019-08-03T14:46:53 (imported from GitLab project)

  • Ghost User enabled an automatic merge when the pipeline for a67f2ed6 succeeds

    enabled an automatic merge when the pipeline for a67f2ed6 succeeds

    By Jean-Baptiste on 2019-08-03T14:46:57 (imported from GitLab project)

  • Ghost User mentioned in commit cd9a45ee

    mentioned in commit cd9a45ee

    By Jean-Baptiste on 2019-08-03T14:47:46 (imported from GitLab project)

  • merged

    By Jean-Baptiste on 2019-08-03T14:47:46 (imported from GitLab project)

  • I have the feeling this is the wrong way of solving it. I think we should replace all these urls by just one of the form /sources/(?P<source>\w+)/. This wouldn't need any reinstanciation.

    What do you think?

  • Author Contributor

    We could but it implies to change the model of LDPSource to have one LDPSource per 'type' (with a list of urls) instead of a list of sources merged by 'type' into a container at the client request.

    So, since it works now, my advice is to wait a real need to change it (performance issue, or any issue when a model refactor will ease to solve the problem)

    By Jean-Baptiste on 2019-08-05T12:46:35 (imported from GitLab project)

  • I don't get your point.

    I think we should take this opportunity to do directly the clean way instead of adding technnical debt.

Please register or sign in to reply
Loading