Unable to change solid-form-search label-xyz dynamically

Version: 0.14

I can't change the label-xyz of a solid-form-search after this one have been generated.

jsbin: https://jsbin.com/qurebegoca/1/edit?html,output

Indeed this is a bug, the callback of the label attribute does not trigger a render but it should: https://git.startinblox.com/framework/sib-core/blob/master/src/new-widgets/baseWidgetMixin.ts#L27

assigned to @manonbou

added BUG label

Actually, it's a bit more complicated that what I said above.

@jbpasquier do you need to change the label on the solid-form-search or directly on the widget?

@manonbou In the first case, we probably need to use a mutationObserver, because we cannot know at first which attributes we will have to listen

In the second case, we can just add a callback on the widget for the attribute label

@jbpasquier I would also say that changing the attribute on the widget, if possible, would be better in terms of performances. If you change it on the component, you need to re-render it entirely

@balessan any thoughts on this?

@manonbou tested and attaching a MutationObserver to a component to re-render it as soon as an attribute change seems to cause a lot of problems. We have a lot of additional renders and it means detaching widgets from the DOM to create new one, which seems very bad in terms of performances

I guess that both could be considered as a bug?

If I need to do the widget thing, that mean duplicate core widgets.

I'm not sure I understood your point. What I was saying is, instead of changing the label-field attribute on the component, you can change the label attribute on the widget directly. But this won't duplicate anything.

Ok, got it.

Well, it may have some unexpected effect whenever the widget would get reloaded, the i18n script may or may not pass on it without #732 (closed)

Yes indeed, so I think we should solve #732 (closed) for this use case.

mentioned in issue applications/hubl#940 (closed)

mentioned in issue #755

mentioned in issue #782