Skip to content

bugfix: reactive update with right context

Matthieu Fesselier requested to merge bugfix/context-and-reactivity into dev

With this fix, after publishing a new comment, the author name should show up.

Test case:

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <meta http-equiv="X-UA-Compatible" content="ie=edge" />

    <script type="module" src="/sib-core/dist/index.js"></script>
    <script type="module" src="https://unpkg.com/@startinblox/oidc@0.8"></script>
    <script data-default-context type="application/ld+json">
    {
      "author": "http://happy-dev.fr/owl/#author_user"
    }
    </script>
  </head>
  <body>
    <sib-auth>
      <sib-auth-provider
        data-authority="https://api-staging.coopstarter.happy-dev.fr/"
      ></sib-auth-provider>
    </sib-auth>

    <button id="login">Login</button>

    <solid-form
      data-src="https://api-staging.coopstarter.happy-dev.fr/conversations/"
      fields="title"
    ></solid-form>

    <solid-display
      data-src="https://api-staging.coopstarter.happy-dev.fr/conversations/"
      fields="title, author.name"
    ></solid-display>

    <script>
      login.onclick = () => document.querySelector('sib-auth').login()
    </script>

  </body>
</html>

Merge request reports