Skip to content

bugfix: use skypack for pubsub

Matthieu Fesselier requested to merge bugfix/skypack-pubsub into beta

Change for using pubsub from Skypack. A bug occured randomly with the reactivity when 2 local versions from pubsub were loading (router and core). A first one was registering the events, and a second one sending them.

Here is a test case:

<head>
  <script type="module" src="https://unpkg.com/@startinblox/core@beta"></script>
  <script type="module" src="https://unpkg.com/@startinblox/router@0.11"></script>
</head>

<solid-router keep-url>
  <solid-route name="edit">edit</solid-route>
</solid-router>

<div data-view="edit">
  <solid-widget name="add-thematique-widget">
    <template>
      <solid-form
        data-src="data/list/users.jsonld"
        fields="name"
      ></solid-form>
    </template>
  </solid-widget>

  <solid-form
    data-src="data/list/events.jsonld"
    fields="thematique, add-thematique"

    widget-thematique="solid-form-dropdown-multipleselect-autocompletion"
    range-thematique="data/list/users.jsonld"

    widget-add-thematique="add-thematique-widget"
    submit-button="Ajouter une exposition"
  ></solid-form>
</div>

In this case, when the form for adding the thematique was submitted, the autocomplete list was sometimes not updated.

Loading the module from skypack ensure only 1 version is loaded. Related to sib-router!58 (merged) in router

Edited by Matthieu Fesselier

Merge request reports