On Circle's administration page, "Join / Leave" buttons are not reactive
Link issues together to show that they're related. Learn more.
Activity
- Ghost User changed milestone to %Projects part I
changed milestone to %Projects part I
By Alexandre on 2019-11-14T21:56:09 (imported from GitLab project)
- Ghost User mentioned in issue #251 (closed)
mentioned in issue #251 (closed)
By Alexandre on 2019-11-14T21:57:20 (imported from GitLab project)
- Owner
As it's sib-form, this issue will also fix it when we will find a solution. https://git.happy-dev.fr/startinblox/applications/sib-app/issues/269#note_54032
- Please register or sign in to reply
- Author Contributor
@jbpasquier: We're still waiting for the framework team here, right?
By Alexandre on 2019-11-26T09:13:56 (imported from GitLab project)
- Owner
Still no true solution here, yes. We want a store.
- Author Contributor
- Calum Mackervoy assigned to @calummackervoy and unassigned @jbpasquier
assigned to @calummackervoy and unassigned @jbpasquier
- Maintainer
the sib-delete case (leave circle) should be fixed when sib-delete
resourceDeleted
is refreshing sib-displaysthe sib-form case (join circle) isn't working, when it should be - I did some debugging and I found that the sib-form doesn't emit a
save
event when you click join circle? It could be because it lacks a data-src or because it uses hd-inherit-user-id and similar?the join circle sib-form:
data-src='' nested-field='members' fields='user.@id' label-user.@id='' value-user.@id='' widget-user.@id='sib-form-hidden' hd-inherit-bind-user2input="input[name='user.@id']" hd-inherit-widgets submit-button='Join Circle'
- Maintainer
I'm not sure why but to be sure, you can listen the
save
event onbody
as it bubbles. Then you can access the relatedsib-form
inevent.target
- Maintainer
nice one :D this is working, will MR once leave circle is working (waiting on !89 (merged) to test) :)
- Owner
@calummackervoy Is the @matthieu solution working here?
- Maintainer
yeah - currently join updates as expected, but the following is being done to finish the MR
leave is not working:
- clicking leave the button disappears but 'join circle' does not appear
- this is because leave displays on the resource circle-member/X/, but its container displays on circle/Y/members/, which hasn't been cleared
the left side-menu is not updated to add or remove circles/projects which you've joined. These work on circles/X/
bit of a mess! I'm working on this at the moment with Matthieu and we'll MR once these problems are worked around. They will both be fixed properly by having a reactive store
Edited by Calum Mackervoy
- Calum Mackervoy changed time estimate to 4h
changed time estimate to 4h
- Calum Mackervoy added 1h 30m of time spent at 2020-01-08
added 1h 30m of time spent at 2020-01-08
- Owner
@calummackervoy Does https://git.happy-dev.fr/startinblox/framework/sib-core/issues/558 ending satisfy needs here?
Edited by Jean-Baptiste Pasquier
- Author Contributor
@calummackervoy UP ;)
By Alexandre on 2020-01-31T06:55:37 (imported from GitLab project)
- Calum Mackervoy added 2h of time spent at 2020-01-31
added 2h of time spent at 2020-01-31
- Maintainer
I've been working on this and still having some issues
I'm in correspondence with @matthieu to solve these, but to summarise:
-
circle
is defined on the resource, but when I need it most it isn't... I think this is because another call is clearing the resource before I get to it - join circle/project doesn't update the left side-menu to display the new group. I've opened issue #380 (closed) for this but it's the same solution (this time clearing
user/X/circles/
alongsidecircle-members/Y
)
Edited by Calum Mackervoy -