Those buttons work well, meaning that I am indeed removed from or added to the targetted circle:
However the buttons are not reactive, meaning that nothing happens with I click on them. The left column is also not reactive. That's very confusing for the end user who thinks nothing happened.
Designs
Child items
...
Show closed items
Linked items
0
Link issues together to show that they're related.
Learn more.
@matthieu, @balessan, @sylvain, @clement: What do we want?! A store! When do we want it?! Now! What do we want?! A store! When do we want it?! Now! What do we want?! A store! When do we want it?! Now! [...] :)
By Alexandre on 2019-11-28T19:20:21 (imported from GitLab project)
the sib-delete case (leave circle) should be fixed when sib-delete resourceDeleted is refreshing sib-displays
the sib-form case (join circle) isn't working, when it should be - I did some debugging and I found that the sib-form doesn't emit a save event when you click join circle? It could be because it lacks a data-src or because it uses hd-inherit-user-id and similar?
yeah - currently join updates as expected, but the following is being done to finish the MR
leave is not working:
clicking leave the button disappears but 'join circle' does not appear
this is because leave displays on the resource circle-member/X/, but its container displays on circle/Y/members/, which hasn't been cleared
the left side-menu is not updated to add or remove circles/projects which you've joined. These work on circles/X/
bit of a mess! I'm working on this at the moment with Matthieu and we'll MR once these problems are worked around. They will both be fixed properly by having a reactive store
I've been working on this and still having some issues 🙈
I'm in correspondence with @matthieu to solve these, but to summarise:
circle is defined on the resource, but when I need it most it isn't... I think this is because another call is clearing the resource before I get to it
join circle/project doesn't update the left side-menu to display the new group. I've opened issue #380 (closed) for this but it's the same solution (this time clearing user/X/circles/ alongside circle-members/Y)