@ all mention not working in one particular circle
What's happening?
Circle coworking-invasion-paris was missing the "@_all" mention. Other circle in this instance worked fine.
Re-saving the circle in the admin fixed the problem.
I'm filing this issue in order to find why and avoid having this problem again.
Steps to reproduce
No idea as re-saving the circle fixed the problem. Before, typing "@all" didn't give anything
Relevant logs and/or screenshots
Your Environment
- Browser name and version: Firefox 73 and Chrome
- Operating System and version (desktop or mobile): Desktop
Activity
- Rachel added 1 deleted label
added 1 deleted label
@jbpasquier does this ring a bell? Alex gave me the workaround to fix the problem so I guess it already occured? Searching for it didn't gave me any issue though.
- Please register or sign in to reply
- Maintainer
you typed
@all
but it should be@_all
right?I'm not sure why we have a _ but I'd tend to consider it a bug...
- Rachel changed title from {-
@all
-} mention not working in one particular circle to @ all mention not working in one particular circlechanged title from {-
@all
-} mention not working in one particular circle to @ all mention not working in one particular circle - Owner
Absolutely related to https://git.happy-dev.fr/startinblox/applications/sib-app/issues/256 and changes made on prosody while we didn't had @MattJ
- Owner
From what I remember, the
_
is to prevent the case where someone haveall
as username. Anyway, it's a little change on prosody's module to call it whatever we want.
- Maintainer
Maybe we should prevent people from using all as a nickname.
How does it work in rocketchat / slack ?
Ok so best is to close this and keep #256 (closed) only?
- Owner
In many chats like slack, you can mention specifically a group of users like:
- "@here": Only online user of the channel
- "@everyone": Online and offline users
- "@channel": Every users of the channel, same as everyone
- Some chats also offers "@groupName", with which you can mention users in a particular group
In our case, we stated to provide only the "@all" for now who works as the "@everyone". The "_" also ensure that it's always on top of the list even if there are an "alex" on the list. :)
In all platform I've tested, you've no username restriction, but the "all" or the "everyone" is not displayed the same way as an user.
On slack, you can even mention external users too.
For technical side, Prosody provide the list of each users to converse, we added a fake one named "_all", we also intercept on prosody mentions with this "_all" to send a notification to every users instead of only one. From converse side, it works like every other users.
Edited by Jean-Baptiste Pasquier
- Maintainer
I think all should be on top, even if there is an alex. Adding the _ seems like a bad ux choice to me.
My point was: What happens in slack if you create a user with "everyone" as a username, or "all" in rocket chat?
- Owner
You can on slack, it works fine, as the "all" is not treated as a user. If you want this kind of behavior on our system, that mean that we need to handle it on converse side instead of prosody. But as converse has no knowledge of who is linked with which jabberID, it'll have to ask prodosy for all of them - we will need a custom process all long as XEP-0372: References is made to mention only one user and not a set of users.
Notice that slack order is more a personal one, you'll always have "Person on this channel, ordered by last mention you did" then other persons and channel/here mention, with the same order - the last mention/talk you did/had.
- Maintainer
I guess it's up to @rachel to decide what the right ux is, and how to deal with the priorities. I was just trying to point out that other systems seem more user friendly to me :)
closing in favour of https://git.startinblox.com/applications/sib-app/issues/256
- Rachel closed
closed