Prosody may send error with 200 message

Currently there's nothing to handle an error from Prosody in the body of a 200 response

I'm updating DjangoLDP to store response bodies on activities (see !33 (merged) ), but it will still look like a success in the list view of the admin panel

We will want to define some code to log an error to sentry when there is an error in the response

Tasks

• ActivityQueue will need to provide support for a callback function for our package: djangoldp#283 (closed)
• I'll need to know what a Prosody 200 error looks like
• With these, we can schedule a callback which just logs an error to the Sentry server

@jbpasquier @MattJ do you have an example of an error from Prosody which passes the status 200?

Whenever I come across an error, I should just log it with logger.error('...')? This will notify the Sentry server

@MattJ will be able to tell you the format he chose.

Usually those errors come when you save a Circle, Prosody register it and one or more of its members is a 404 (or any other error code) and is ignored. Meaning that "Yeah, your circle is created/saved/usable, but no, the integrity of the member list is not here."

ActivityQueue is ready for this @MattJ

@calummackervoy Hey, I just deployed to the dev server.

Format is this on success:

Status code : 200 OK

Content-Type : application/json

Payload:

{
  "id": "change id"
}

Format is this on error:

Status code : 500 or a more specific HTTP error code

Content-Type: : application/json

Payload:

{
  "id": "change id",
  "type": "error type",
  "condition": "error condition",
  "text": "optional error text"
}

@MattJ What if you have an error but still, it's a 200?

Say a circle creation, but one of its members does not exists. It must be a 200 OK because the circle is created properly, just one of its members does not exist.

It currently returns status 500 with the text "Error while updating one or more room members".

I can change this to return success, but then what happens?

The circle is successfully saved, the missing member is ignored.

This is because those kind of request are made on two-or-more steps:

• Create the circle
• Affiliate its members

The second part lead to sub-requests for each members, but it's not the responsibility of the server who host the circle to ensure that every users of distant servers exists properly and that their server is reachable, without any network issue, etc.

When a member does not exist, the request is still successful as the circle exist and, potential other members are in.

Prosody applies changes for all members that it can. If a member fails (for any reason) the error is caught and saved and it continues.

After all members are processed in this way, if the number of saved errors >0 then each error gets logged, and Prosody will respond with an error instead of success to Django.

Problem here is if the user is a 404 and you return a 500 to Django, Django may simply retry 2 more times to re-send you the request and then consider that it was a failure.

Maybe we can use a 201 Created 202 Accepted with an error message? Does it fit better for you?

I created a user idonotexist with a non-existent external urlid

From XMPP I receive 200 with just an id in the body: https://api.test1.startinblox.com/admin/djangoldp/activity/585/change/

From Jabber I receive the following 500: https://api.test1.startinblox.com/admin/djangoldp/activity/586/change/

Is this expected?

you return a 500 to Django, Django may simply retry 2 more times to re-send you the request and then consider that it was a failure

@jbpasquier I was planning to remove 500 from the list of statuses to retry on?

Jabber (jabber.happy-dev.fr, right?) is the production, without the Matthew's new feature.

XMPP (xmpp-dev.startinblox.com?) is the preproduction, with the Matthew's new feature.

@MattJ The first one should not have send a 200, isn't it?

Receiving 200 from pre-production with only an id though there's no way to tell that there was a 404 internally?

Shouldn't it be failing loudly?

I can't see what's behind the URLs you linked, I just get a login page that won't let me in.

Can you tell the id you received?

{"id":"ybsMN8Af"}

I created an admin account for you, login with it and you'll see the payload

Thanks. @calummackervoy retry - the issue should be fixed now.

Response: {"id":"nI3EKuFX","type":"cancel","condition":"undefined-condition","text":"Error while updating one or more room members"}

@MattJ Do we want to include related not working users or will it be included on the Prosody's log to Sentry components/solid-xmpp-chat#185 (closed) ?

I currently avoid leaking any potentially private info via the error responses (as it is not authenticated in any way). The details are logged in Prosody's log (which would be sent to Sentry), and they include the change id for correlation purposes.

Perfect.

@calummackervoy Could you include the id on the feedback to Sentry?

@jbpasquier https://sentry.startinblox.com/organizations/hubl/issues/85/

Would be nice to have the id as a tag, but, as is, that's fine for a release! :)

mentioned in issue components/solid-xmpp-chat#188 (closed)

@MattJ receiving unexpected error back from Prosody on this activity: https://api.test1.startinblox.com/admin/djangoldp/activity/707/change/

{"id":"1Qp2jO63","type":"cancel","condition":"undefined-condition","text":"Error while updating one or more room members"}

I've deleted the user idonotexist and then edited the circle, I was expecting success back

https://api.test2.startinblox.com/users/patachon/ does not exists too

Removed this user but still have an error from https://api.test1.startinblox.com/admin/djangoldp/activity/713/change/

{"id":"VVKuNPl_","type":"cancel","condition":"undefined-condition","text":"Error while updating one or more room members"}

It considers the following members invalid because they do not have a "user" with an "@id". I can't verify right now because test1 seems to be down.

• https://api.test1.startinblox.com/circle-members/8/
• https://api.test1.startinblox.com/circle-members/4/

Sorry @MattJ we wiped the database!

I've reproduced the error on the new setup: https://api.test1.startinblox.com/admin/djangoldp/activity/3/change/

{"id":"uHu1dQHf","type":"cancel","condition":"undefined-condition","text":"Error while updating one or more room members"}

Hi @calummackervoy - looking into this now, but looks like the circle was modified (and succeeded this time).

@MattJ Tried to save the circle again, got those response:

{"id":"AyoD0x2e","type":"cancel","condition":"undefined-condition","text":"Error while updating one or more room members"}

{"id":"8CyT2yO6","type":"cancel","condition":"undefined-condition","text":"Error while updating one or more room members"}

The room only have one member, which exists

@calummackervoy Any idea why the activity is triggered two times here?

Issue is on djangoldp side, @jblemee is investigating, if I set the SERIALIZER_CACHE to False, it works fine.

The cache is the cause of the error from Prosody or of the duplicate activities?

Issue of the error from Prosody.

The duplicate activities were my error during testing - manually started a duplicate ActivityQueueService using manage.py shell on test1

mentioned in issue components/solid-xmpp-chat#208 (closed)

closed

mentioned in issue applications/hubl#816 (closed)