Emoji Reaction to messages

This is relevant:

https://github.com/jabbercat/jabbercat/issues/80

By JC Brand on 2018-03-21T07:33:50 (imported from GitLab project)

Interesting. I guess that wouldn't be the easiest feature to add. On the other hand that's not the most important either :)

By Sylvain Le Bon on 2018-03-21T11:29:12 (imported from GitLab project)

I agree, on the short run this is not very important if we lose it while migrating on the chat component.

However on the medium to long run, I do believe it is quite important. It is one of the most used feature on the chat currently, and triggers reactions that would not otherwise be sent as plain messages I believe. I makes the chat a friendlier place.

By Alexandre on 2018-03-21T14:56:11 (imported from GitLab project)

@nyco : You told me you had implemented reactions to messages on ConverseJS, right ?

If I didn't fantasized this, I'd love to see it.

By Alexandre on 2019-09-02T20:40:28 (imported from GitLab project)

@nyco : UP :-)

By Alexandre on 2019-09-03T12:35:28 (imported from GitLab project)

added 1 deleted label

The plan would be to implement this experimental XEP as a Converse plugin

added 1 deleted label and removed 1 deleted label

changed time estimate to 1d

mentioned in merge request components/solid-xmpp-chat!30 (closed)

This is now implemented in merge request 30

It look like this

To add a reaction, use the smiley icon for the selected message like this

mentioned in commit components/solid-xmpp-chat@b7b79b8c

@XaviFP @jbpasquier Do we know where we are on this one?

Nowhere, todo

mentioned in issue components/solid-xmpp-chat#134 (moved)

Renan Savidan and Alice asked for this one. Alice actually consistently makes fun of Hubl because we're lacking this feature.

Is the 1d estimate includes components/solid-xmpp-chat#134 (moved)? Do we need components/solid-xmpp-chat#134 (moved)? I thought we had concluded we didn't.

If it is only a day, I'd implement it.

A lot of people are asking for this indeed We had prioritized it in the MVP before. So I think the estimation here are still Dele's estimation?

I also thought so. @XaviFP What do you say?

@alexbourlier I need some time to asses that. There is an open debate in the community regarding how to fasten attachments to messages, but as soon as I've done some research I'll come back and let you know.

Cool. We might have a community willing to fund it if they judge it affordable.

@XaviFP Any update here?

@XaviFP ?

Sorry for the delay @alexbourlier. After some investigation it seems the most likely solution right now would be to go with XEP-444. I don't have an estimate and estimating this will take some time. I also feel we should prioritise other tasks first but of course you have the last word. What do you think?

Thanks.

As a general note, we do not move fast enough on chat related features. Is something wrong somehow? Should we plan a call to discuss this?

Specifically on that feature, users are strongly asking for it. What else would you prioritize higher than this one on the chat component?

@alexbourlier Talking with @MattJ and @jbpasquier I got the impression that RAI issues needed to be focused on, but that's just the impression I got. Of course it's not something that prevents paving the path for others meanwhile. That said, I'm happy to take on this one. Let me look up a last couple of things I need to check and come back with an estimate.

@XaviFP Yes totally, RAI is of higher priority than reaction to message.

@manv If RAI is still too daunting, this one might be a good next one

@manv possible to have an estimation here ? Grazie :)

this one might be a good next one

This one is definitely an harder one.

@jbpasquier Don't be scared

Jokes aside, my understanding from Dele's discussion was that it wasn't, but you know better

This one is definitely an harder one.

Absolutely. I just reached out to some XMPP folk to find out what the latest is on reactions (I believe they are implemented in Movim at least).

I can prepare a document detailing the XMPP side of the work that @manv can use to estimate. The UI, I'll leave to someone else :)

Bad news

Bad news

Actually I just heard from the Movim author. They are using XEP-0444, which I just re-reviewed.

The good news is that sending reactions is very very easy. And there is no server-side work required.

What is going to mess things up is displaying the reactions. Using the approach in XEP-0444, each reaction is represented as a separate message, and they are aggregated by the client. It's going to add to the "invisible messages" problem that currently breaks Converse.js history sync.

I'd recommend that solving history sync is prioritized first. When we have reliable history, then it should actually be fairly easy to build reactions on top.

Could XEP-0427 help us somehow?

XEP-0427 is my preferred solution, as it provides server-side aggregation which I think will be more reliable than client-side aggregation. With client-side aggregation there is the potential for bugs where different clients show different reactions (especially when reactions and the original message span a long period of time).

Consider someone sending a reaction to a message that happened months ago. The client would need to count through months of history messages to determine the correct reactions to show for the original message. On the server-side (as in XEP-0427's approach) it would be simple to just increment a counter as the reaction is entered into the archive.

But XEP-0427 is more work to implement on the server side, and the protocol is not exactly finished (there were some disagreements about the best way to organize the counts... reactions are not the only use-case for this aggregation feature). Of course if we wanted to go that route, we can just forge the path as we go (implementation experience is a good way to get XEPs updated).

The reality is that XEP-0444 is probably "good enough". Most reactions happen within a short period of time, and if Converse.js is reliably syncing history then there should be no problems, in theory... :)

OK, that was my understanding.

So we're basically saying that this issue in its basic version is somewhat trivial, but we'll bump into our history issues even more often with it being activated.

Did anyone talked to JC Brand about the history issue? I'd love his recommendation

I spoke with JC about it months ago. I link to this comment a lot :)

components/solid-xmpp-chat#176 (comment 35145)

Indeed, this one looks familiar.

@jbpasquier @manv Has this setting been activated since then?

We're using the in memory implementation by @XaviFP now. This parameter is not relevant anymore.

@jbpasquier @manv OK

And did any of you spoke to JC since then to discuss the history loading issues we're having?

No, it's not directly related to Converse. We know from where it is, Xavier was on it before.

It's because of an error in the event management when scrolling, I don't know details though.

Hmmm... so you mean it is a solid-xmpp-chat problem only?

It's a converse within Solid XMPP Chat issue. Remove the Solid XMPP Chat layer and you'll have no issue. :-)

That sounds like a good news to me. It means :

Having emoji reactions to message is simple
Solving our history loading issues also is

Correct?

When do we start?

With a quote from @manv ! :)

@manv You heard the man

Let make it 10 days

I'm halfway through at the moment, so next week we should be able to have something to test on beta

@manv nice to heard !

Let make it 10 days

@manv You mean 10 days for a delivery? Not 10 days of work, right? Could you estimate this issue with tokens? (1 token = 7€)

Ah ah, same reaction as @jbpasquier

hey @manv Is there something we can test here ? thx

@Cyrilthiriet You don't even have validated or paid for something here. :-)

@manv needs to add his token estimation here.

@jbpasquier that's the american dream :) I 'm gonna buy a fridge just after with token at Darty !

Indeed @manv how long/much it'll cost please ? eheh

This issue is the oldest of which I track, 1091 Days, this is her or me, deliver or dying that's it :)

@Cyrilthiriet 200 tokens

Read reactions and display them under a message (with a count for each one)
Add a message action to send a reaction
Clicking on a message reaction, toggle it for the current user (add or remove)
Use a custom emoji picker components/solid-xmpp-chat#241 (closed)
If a message has reactions, add a button next to them to quickly add a new one

Aouch, that's expensive.

@manv Thanks for the great spec. It's good work.

@Cyrilthiriet I think we should go, that's the most asked feature and I know from a fact that it drives engagement big time.

@Berengere If Happy Dev Paris splits the bill, we like unicorns in the night sky of Patagonia: we shining

@alexbourlier I'm ok but not right now, let's discuss about it. See what @Berengere say as well.

Yeah, I realized there is a lot of work underneath even if it's quite simple to implement

@manv after a long discussion with @alexbourlier we said G︎ for this one. Are you able to give us an estimation on when it could be delivered ? Hopefully @Berengere should bet on it as well. It's clear we really need to have this on Hubl